NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-127389 - fix 'Uops Executed' display in summarize_stats.py#127396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

alonme wants to merge5 commits intopython:main

base:main

Choose a base branch

fromalonme:gh-127389

Open

gh-127389 - fix 'Uops Executed' display in summarize_stats.py#127396

alonme wants to merge5 commits intopython:mainfromalonme:gh-127389

+6 −5

Conversation

Copy link

Contributor

alonme commentedNov 29, 2024•
edited by bedevere-appbot
Loading

fix 'Uops Executed' display in summarize_stats.py and some type hints

Issue:Uops Executed displayed wrong inTools/scripts/summarize_stats.py #127389

pythongh-127389- fix 'Uops Executed' display in summarize_stats.py

6645fb5

bedevere-appbot mentioned this pull request

Nov 29, 2024

Uops Executed displayed wrong inTools/scripts/summarize_stats.py#127389

Open

bedevere-appbot added the awaiting review label

Nov 29, 2024

Merge branch 'main' intopythongh-127389

152a74a

ZeroIntensity added the skip news label

Nov 30, 2024

ZeroIntensity reviewed

Nov 30, 2024

View reviewed changes

Tools/scripts/summarize_stats.py OutdatedShow resolvedHide resolved

alonme added2 commits

November 30, 2024 14:29

revert typo fix

c336e18

Revert import formatting

21b8c83

ZeroIntensity reviewed

Nov 30, 2024

View reviewed changes

Tools/scripts/summarize_stats.py OutdatedShow resolvedHide resolved

Revert unrelated type hint fixes

de807d2

ZeroIntensity reviewed

Nov 30, 2024

View reviewed changes

Tools/scripts/summarize_stats.py

		@@ -442,7 +443,7 @@ def get_gc_stats(self) -> list[dict[str, int]]:
		gc_stats[gen_n][name] = value
		return gc_stats

		def get_optimization_stats(self) -> dict[str, tuple[int, int \| None]]:
		def get_optimization_stats(self) -> dict[Doc, tuple[int, int \| None]]:

Copy link

Member

ZeroIntensityNov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is also unrelated, right?

Copy link

ContributorAuthor

alonmeNov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I believe it is related, as the fix for the issue is to treat the value returned from this function as a doc and not a str, so it makes the patch clearer