Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127385: AddF_DUPFD_QUERY tofcntl#127386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 9 commits intopython:mainfromrruuaanng:package-all-ins
Apr 24, 2025

Conversation

rruuaanng
Copy link
Contributor

@rruuaanngrruuaanng commentedNov 29, 2024•
edited
Loading

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is trying to do too many things. I don't really see the need for the switch to a new macro, but if we do end up doing that, it should be in another PR. Please revert that and keep this focused on the one new macro.

rruuaanng and erlend-aasland reacted with thumbs up emoji
@rruuaanng
Copy link
ContributorAuthor

@ZeroIntensity
I think you are right. Can you help me convert it into a draft? I'm mobile now.

ZeroIntensity reacted with thumbs up emoji

@ZeroIntensityZeroIntensity marked this pull request as draftNovember 29, 2024 06:28
@rruuaanngrruuaanng marked this pull request as ready for reviewNovember 29, 2024 06:43
@erlend-aaslanderlend-aasland dismissedZeroIntensity’sstale reviewNovember 29, 2024 08:09

The requested changes were addressed

@erlend-aasland
Copy link
Contributor

This PR is trying to do too many things. I don't really see the need for the switch to a new macro, but if we do end up doing that, it should be in another PR. Please revert that and keep this focused on the one new macro.

@rruuaanng, please take Peter's words into account for future contributions. That piece of advice is also spelled out in the devguide.

@erlend-aasland
Copy link
Contributor

I'll land this in a day or two.

@erlend-aaslanderlend-aasland self-assigned thisNov 29, 2024
@rruuaanng
Copy link
ContributorAuthor

This PR is trying to do too many things. I don't really see the need for the switch to a new macro, but if we do end up doing that, it should be in another PR. Please revert that and keep this focused on the one new macro.

@rruuaanng, please take Peter's words into account for future contributions. That piece of advice is also spelled out in the devguide.

Yes, So I've completed his suggestion. I almost forgot it in the process :)

@erlend-aaslanderlend-aasland changed the titlegh-127385: Add latest F_DUPFD_QUERY constants to fcntl modulegh-127385: AddF_DUPFD_QUERY tofcntlNov 29, 2024
@erlend-aaslanderlend-aasland linked an issueNov 29, 2024 that may beclosed by this pull request
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you :)

rruuaanng reacted with thumbs up emoji
@rruuaanng
Copy link
ContributorAuthor

Hold on, I need to add a document for fcntl, and I found the addition log in the existing documentation. And I confirmed that there is no corresponding document for my other PR

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

rruuaanng reacted with thumbs up emoji
@serhiy-storchakaserhiy-storchaka merged commit8e18a9d intopython:mainApr 24, 2025
41 checks passed
@rruuaanngrruuaanng deleted the package-all-ins branchApril 25, 2025 00:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddF_DUPFD_QUERY tofcntl
4 participants
@rruuaanng@erlend-aasland@serhiy-storchaka@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp