Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-127359: Pin Tcl/Tk to 8 (8.6) for testing macOS#127365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 3 commits intopython:mainfromhugovk:3.14-pin-tcl-tk-8.6
Nov 28, 2024

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedNov 28, 2024
edited by bedevere-appbot
Loading

@hugovkhugovk added topic-tkinter needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes infraCI, GitHub Actions, buildbots, Dependabot, etc. labelsNov 28, 2024
@hugovkhugovk changed the titlePin Tcl/Tk to 8 (8.6) for testing macOSgh-127359: Pin Tcl/Tk to 8 (8.6) for testing macOSNov 28, 2024
run: brew install pkg-config openssl@3.0 xz gdbm tcl-tk make
run: |
brew install pkg-config openssl@3.0 xz gdbm tcl-tk@8 make
brew link tcl-tk@8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know brew: what is this newbrew link tcl-tk@8 command?brew install is not enough? Maybe add a comment to explain it?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Becausetcl-tk@8 is an alternative version and not the latest, it installs as so-called"keg-only", which means it doesn't get symlinked into the usual paths:

brew info tcl-tk@8==> tcl-tk@8: stable 8.6.15 (bottled) [keg-only]Tool Command Languagehttps://www.tcl-lang.orgInstalled/opt/homebrew/Cellar/tcl-tk@8/8.6.15 (3,069 files, 35.7MB)  Poured from bottle using the formulae.brew.sh API on 2024-11-28 at 14:38:32From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/t/tcl-tk@8.rbLicense: TCL==> DependenciesRequired: openssl@3 ✔==> CaveatsThe sqlite3_analyzer binary is in the `sqlite-analyzer` formula.tcl-tk@8 is keg-only, which means it was not symlinked into /opt/homebrew,because this is an alternate version of another formula.If you need to have tcl-tk@8 first in your PATH, run:  echo 'export PATH="/opt/homebrew/opt/tcl-tk@8/bin:$PATH"' >> ~/.zshrcFor compilers to find tcl-tk@8 you may need to set:  export LDFLAGS="-L/opt/homebrew/opt/tcl-tk@8/lib"  export CPPFLAGS="-I/opt/homebrew/opt/tcl-tk@8/include"For pkg-config to find tcl-tk@8 you may need to set:  export PKG_CONFIG_PATH="/opt/homebrew/opt/tcl-tk@8/lib/pkgconfig"==> Analyticsinstall: 12,709 (30 days), 12,737 (90 days), 12,738 (365 days)install-on-request: 280 (30 days), 310 (90 days), 310 (365 days)build-error: 8 (30 days)

Perhaps a comment like?

brew install pkg-config openssl@3.0 xz gdbm tcl-tk@8 make# Because alternate versions are not symlinked into place by default:brew link tcl-tk@8

vstinner reacted with thumbs up emoji
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. You might add a comment onbrew link or not, it's up to you.

hugovk reacted with thumbs up emoji
@hugovkhugovk merged commitb83be9c intopython:mainNov 28, 2024
36 checks passed
@hugovkhugovk deleted the 3.14-pin-tcl-tk-8.6 branchNovember 28, 2024 17:03
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker b83be9c9718aac42d0d8fc689a829d6594192afa 3.13

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker b83be9c9718aac42d0d8fc689a829d6594192afa 3.12

hugovk added a commit to hugovk/cpython that referenced this pull requestNov 29, 2024
@bedevere-app
Copy link

GH-127393 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 29, 2024
@bedevere-app
Copy link

GH-127394 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 29, 2024
hugovk added a commit to hugovk/cpython that referenced this pull requestNov 29, 2024
…onGH-127365)(cherry picked from commitb83be9c)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker b83be9c9718aac42d0d8fc689a829d6594192afa 3.9

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker b83be9c9718aac42d0d8fc689a829d6594192afa 3.11

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker b83be9c9718aac42d0d8fc689a829d6594192afa 3.10

@bedevere-app
Copy link

GH-127407 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelNov 29, 2024
@bedevere-app
Copy link

GH-127408 is a backport of this pull request to the3.10 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.10only security fixes labelNov 29, 2024
@bedevere-app
Copy link

GH-127409 is a backport of this pull request to the3.9 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.9only security fixes labelNov 29, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@hugovkhugovk

Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.skip newstopic-tkinter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugovk@vstinner

[8]ページ先頭

©2009-2025 Movatter.jp