Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-127257: Add hex code to ssl "unknown error" message#127360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 2 commits intopython:mainfromencukou:ssl-unknown-hex
Jan 10, 2025

Conversation

@encukou
Copy link
Member

@encukouencukou commentedNov 28, 2024
edited by bedevere-appbot
Loading

This does notfix#127257 but would have made it easier to debug.

  • To make it easier to vary the individual parts of the message,
    replace the if-ladder with a few constant format strings by
    building the string piece-wise using PyUnicodeWriter.

  • Use "unknown error (0x%x)" rather than just "unknown error"
    if we can't get a better error message. (Hex makes sense as
    the error includes two byte-packed parts.)

As there are no cases where weshould raise an "unknown error",
I don't see a good way to add tests. But, we can verify using the
current failure on Arch Linux buildbots.
Existing tests do cover error messages.

To make it easier to vary the individual parts of the message,replace the if-ladder with constant format strings by buildingthe string piece-wise with PyUnicodeWriter.Use "unknown error (0x%x)" rather than just "unknown error" if wecan't get a better error message. (Hex makes sense as the errorincludes two packed parts.)
@encukouencukou changed the titlegh-127257: Add hex code "unknown error" messagegh-127257: Add hex code to ssl "unknown error" messageNov 28, 2024
@encukou
Copy link
MemberAuthor

!buildbot Arch.Linux

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commit87f1452 🤖

The command will test the builders whose names match following regular expression:Arch.Linux

The builders matched are:

  • AMD64 Arch Linux Perf PR
  • AMD64 Arch Linux Asan PR
  • AMD64 Arch Linux VintageParser PR
  • AMD64 Arch Linux Valgrind PR
  • AMD64 Arch Linux Usan PR
  • AMD64 Arch Linux Usan Function PR
  • AMD64 Arch Linux Asan Debug PR
  • AMD64 Arch Linux TraceRefs PR
encukou reacted with hooray emoji

@encukouencukou merged commit802556a intopython:mainJan 10, 2025
42 of 49 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

Assignees

No one assigned

Labels

extension-modulesC modules in the Modules dirtopic-SSL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tests] test_poplib fails with "env changed" on Arch Linux with OpenSSL 3.4: [SYS] unknown error (_ssl.c:2634)

2 participants

@encukou@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp