Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127347: Documenttraceback.print_list#127348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Eclips4 merged 5 commits intopython:mainfromtomasr8:tb-print-list
Dec 3, 2024

Conversation

@tomasr8
Copy link
Member

@tomasr8tomasr8 commentedNov 27, 2024•
edited by github-actionsbot
Loading

@bedevere-appbedevere-appbot added the docsDocumentation in the Doc dir labelNov 27, 2024
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't need blurb entries for documentation changes :)

@Eclips4
Copy link
Member

Eclips4 commentedNov 28, 2024•
edited
Loading

Thank you! Documentation entry looks good for me.

Let's also add aprint_list to thetraceback.__all__ (and you should changeLib/test/test_traceback.py::4491, I think thatdenylist variable is no longer needed)

tomasr8 reacted with thumbs up emoji

@tomasr8
Copy link
MemberAuthor

We don't need blurb entries for documentation changes :)

Yeah I wasn't sure whether I should add it or not, but it was easy to write so I went with it 😄 I can remove it though

@ZeroIntensity
Copy link
Member

Yeah, let's remove it.

@Eclips4
Copy link
Member

Yeah, let's remove it.

I don't think we should remove it. If we exposeprint_list totraceback.__all__, Python users should be able to know about it 🙂

@ZeroIntensity
Copy link
Member

Oh, I was under the impression that was going to be done in a separate PR for backporting (adding to__all__ feels like a feature to me, but missing documentation can go all the way back to 3.12). I'll yield to you :)

Eclips4 reacted with thumbs up emoji

@tomasr8
Copy link
MemberAuthor

Let's also add a print_list to the traceback.all (and you should change Lib/test/test_traceback.py::4491, I think that denylist variable is no longer needed)

Done :)

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@tomasr8tomasr8 mentioned this pull requestNov 29, 2024
@Eclips4Eclips4 added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsNov 30, 2024
@tomasr8
Copy link
MemberAuthor

Based in Serhiy'scomment I believe this should be good to go. How should we handle the backports? Should I create them manually since they should only contain the documentation changes (w/o modifying__all__)?

@ZeroIntensity
Copy link
Member

Triagers can edit izzy's PRs, right? I think you can just let the bot do the automatic backport and then remove it from__all__ manually.

@tomasr8
Copy link
MemberAuthor

Yeah if I can edit the PR, that would make it easier 👍

Eclips4 reacted with thumbs up emoji

@Eclips4Eclips4 merged commit8ba9f5b intopython:mainDec 3, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks@tomasr8 for the PR, and@Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 3, 2024
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`.(cherry picked from commit8ba9f5b)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@Eclips4
Copy link
Member

Thank you, Tomas!

tomasr8 reacted with hooray emoji

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 3, 2024
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`.(cherry picked from commit8ba9f5b)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-127569 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 3, 2024
@bedevere-app
Copy link

GH-127570 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 3, 2024
@Eclips4
Copy link
Member

Yeah if I can edit the PR, that would make it easier 👍

Yup, triagers can push to other forks of python/cpython repo.

@tomasr8
Copy link
MemberAuthor

Yeah if I can edit the PR, that would make it easier 👍

Yup, triagers can push to other forks of python/cpython repo.

Great! I'll edit the backports later today :)

Eclips4 reacted with thumbs up emoji

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.x has failed when building commit8ba9f5b.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/9647) and take a look at the build logs.
  4. Check if the failure is related to this commit (8ba9f5b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/9647

Failed tests:

  • test.test_multiprocessing_spawn.test_misc

Failed subtests:

  • test_large_pool - test.test_multiprocessing_fork.test_misc.MiscTestCase.test_large_pool
  • test_large_pool - test.test_multiprocessing_spawn.test_misc.MiscTestCase.test_large_pool

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line6586, intest_large_pool    rc, out, err= script_helper.assert_python_ok(testfn)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line182, inassert_python_okreturn _assert_python(True,*args,**env_vars)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line167, in_assert_python    res.fail(cmd_line)~~~~~~~~^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line80, infailraiseAssertionError(f"Process return code is{exitcode}\n"...<10 lines>...f"---")AssertionError:Process return code is 1command line: ['/root/buildarea/3.x.angelico-debian-amd64/build/python', '-X', 'faulthandler', '-I', '@test_935942_tmpæ']Traceback (most recent call last):  File"<string>", line1, in<module>from multiprocessing.forkserverimport main; main(10,11, ['__main__'],**{'sys_path': ['/root/buildarea/3.x.angelico-debian-amd64/build/target/lib/python314.zip','/root/buildarea/3.x.angelico-debian-amd64/build/Lib','/root/buildarea/3.x.angelico-debian-amd64/build/build/lib.linux-x86_64-3.14'],'authkey_r':13})~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/forkserver.py", line324, inmain    pid= os.fork()OSError:[Errno 12] Cannot allocate memoryTraceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_969479æ/@test_969479_tmpæ", line4, in<module>with multiprocessing.Pool(200)as p:~~~~~~~~~~~~~~~~~~~~^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/context.py", line119, inPoolreturn Pool(processes, initializer, initargs, maxtasksperchild,                context=self.get_context())  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line215, in__init__self._repopulate_pool()~~~~~~~~~~~~~~~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line306, in_repopulate_poolreturnself._repopulate_pool_static(self._ctx,self.Process,~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^self._processes,^^^^^^^^^^^^^^^^...<3 lines>...self._maxtasksperchild,^^^^^^^^^^^^^^^^^^^^^^^self._wrap_exception)^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line329, in_repopulate_pool_static    w.start()~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/process.py", line121, instartself._popen=self._Popen(self)~~~~~~~~~~~^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/context.py", line300, in_Popenreturn Popen(process_obj)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_forkserver.py", line35, in__init__super().__init__(process_obj)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_fork.py", line20, in__init__self._launch(process_obj)~~~~~~~~~~~~^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_forkserver.py", line59, in_launchself.pid= forkserver.read_signed(self.sentinel)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/forkserver.py", line390, inread_signedraiseEOFError('unexpected EOF')EOFError:unexpected EOF---Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line6586, intest_large_pool    rc, out, err= script_helper.assert_python_ok(testfn)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line182, inassert_python_okreturn _assert_python(True,*args,**env_vars)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line167, in_assert_python    res.fail(cmd_line)~~~~~~~~^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line80, infailraiseAssertionError(f"Process return code is{exitcode}\n"...<10 lines>...f"---")AssertionError:Process return code is 1command line: ['/root/buildarea/3.x.angelico-debian-amd64/build/python', '-X', 'faulthandler', '-I', '@test_938868_tmpæ']Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line6586, intest_large_pool    rc, out, err= script_helper.assert_python_ok(testfn)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line182, inassert_python_okreturn _assert_python(True,*args,**env_vars)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line167, in_assert_python    res.fail(cmd_line)~~~~~~~~^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/script_helper.py", line80, infailraiseAssertionError(f"Process return code is{exitcode}\n"...<10 lines>...f"---")AssertionError:Process return code is 1command line: ['/root/buildarea/3.x.angelico-debian-amd64/build/python', '-X', 'faulthandler', '-I', '@test_969479_tmpæ']Traceback (most recent call last):  File"<string>", line1, in<module>from multiprocessing.forkserverimport main; main(10,11, ['__main__'],**{'sys_path': ['/root/buildarea/3.x.angelico-debian-amd64/build/target/lib/python314.zip','/root/buildarea/3.x.angelico-debian-amd64/build/Lib','/root/buildarea/3.x.angelico-debian-amd64/build/build/lib.linux-x86_64-3.14'],'authkey_r':13})~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/forkserver.py", line324, inmain    pid= os.fork()OSError:[Errno 12] Cannot allocate memoryTraceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_935942æ/@test_935942_tmpæ", line4, in<module>with multiprocessing.Pool(200)as p:~~~~~~~~~~~~~~~~~~~~^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/context.py", line119, inPoolreturn Pool(processes, initializer, initargs, maxtasksperchild,                context=self.get_context())  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line215, in__init__self._repopulate_pool()~~~~~~~~~~~~~~~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line306, in_repopulate_poolreturnself._repopulate_pool_static(self._ctx,self.Process,~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^self._processes,^^^^^^^^^^^^^^^^...<3 lines>...self._maxtasksperchild,^^^^^^^^^^^^^^^^^^^^^^^self._wrap_exception)^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line329, in_repopulate_pool_static    w.start()~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/process.py", line121, instartself._popen=self._Popen(self)~~~~~~~~~~~^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/context.py", line300, in_Popenreturn Popen(process_obj)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_forkserver.py", line35, in__init__super().__init__(process_obj)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_fork.py", line20, in__init__self._launch(process_obj)~~~~~~~~~~~~^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_forkserver.py", line59, in_launchself.pid= forkserver.read_signed(self.sentinel)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/forkserver.py", line390, inread_signedraiseEOFError('unexpected EOF')EOFError:unexpected EOF---Traceback (most recent call last):  File"<string>", line1, in<module>from multiprocessing.forkserverimport main; main(10,11, ['__main__'],**{'sys_path': ['/root/buildarea/3.x.angelico-debian-amd64/build/target/lib/python314.zip','/root/buildarea/3.x.angelico-debian-amd64/build/Lib','/root/buildarea/3.x.angelico-debian-amd64/build/build/lib.linux-x86_64-3.14'],'authkey_r':13})~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/forkserver.py", line324, inmain    pid= os.fork()OSError:[Errno 12] Cannot allocate memoryTraceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/build/test_python_938868æ/@test_938868_tmpæ", line4, in<module>with multiprocessing.Pool(200)as p:~~~~~~~~~~~~~~~~~~~~^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/context.py", line119, inPoolreturn Pool(processes, initializer, initargs, maxtasksperchild,                context=self.get_context())  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line215, in__init__self._repopulate_pool()~~~~~~~~~~~~~~~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line306, in_repopulate_poolreturnself._repopulate_pool_static(self._ctx,self.Process,~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^self._processes,^^^^^^^^^^^^^^^^...<3 lines>...self._maxtasksperchild,^^^^^^^^^^^^^^^^^^^^^^^self._wrap_exception)^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/pool.py", line329, in_repopulate_pool_static    w.start()~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/process.py", line121, instartself._popen=self._Popen(self)~~~~~~~~~~~^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/context.py", line300, in_Popenreturn Popen(process_obj)  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_forkserver.py", line35, in__init__super().__init__(process_obj)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_fork.py", line20, in__init__self._launch(process_obj)~~~~~~~~~~~~^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/popen_forkserver.py", line59, in_launchself.pid= forkserver.read_signed(self.sentinel)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/forkserver.py", line390, inread_signedraiseEOFError('unexpected EOF')EOFError:unexpected EOF---

@tomasr8tomasr8 deleted the tb-print-list branchDecember 3, 2024 16:53
@tomasr8
Copy link
MemberAuthor

The buildbot failure does not seem related to this PR

Eclips4 reacted with thumbs up emoji

Eclips4 pushed a commit that referenced this pull requestDec 4, 2024
Add an documentation entry about `traceback.print_list`Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Eclips4 pushed a commit that referenced this pull requestDec 4, 2024
Add an documentation entry about `traceback.print_list`Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Eclips4Eclips4Eclips4 left review comments

@skirpichevskirpichevskirpichev approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dir

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomasr8@Eclips4@ZeroIntensity@bedevere-bot@skirpichev
[8]ページ先頭
©2009-2025 Movatter.jp