Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127330: Update for OpenSSL 3.4#127331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 10 commits intopython:mainfromencukou:make_ssl_data
Nov 28, 2024
Merged

Conversation

@encukou
Copy link
Member

@encukouencukou commentedNov 27, 2024•
edited by bedevere-appbot
Loading

Addgit describe output to headers generated bymake_ssl_data.py

IMO, this info is more important than the date when the file was generated.
It does mean that the tool now requires a Git checkout of OpenSSL, not for example a release tarball.

I've regenerated the older file to add the info. To the other older file I added a note about manual edits.

Add notes on how to add a new OpenSSL version

I believe that what I wrote is the correct process.ssl experts, do you want to you verify?@jackjansen,@tiran,@dstufft,@alex

Add 3.4 error messages and multissl tests

Hopefully we'll start getting fewer[SYS] unknown error in tests! (See#127257)

Also:- Avoid the deprecated `datetime.datetime.utcnow()`- Fix newlineThis requires that the OpenSSL source tree is a Git checkout,and that you have Git installed. Both should be fine for a toolrun manually by people who can change the tool.
@encukouencukou changed the titlegh-27330: Update for OpenSSL 3.4gh-127330: Update for OpenSSL 3.4Nov 27, 2024
@encukou
Copy link
MemberAuthor

!buildbot Arch

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commitea72022 🤖

The command will test the builders whose names match following regular expression:Arch

The builders matched are:

  • AMD64 Arch Linux Perf PR
  • AMD64 Arch Linux Asan PR
  • AMD64 Arch Linux Valgrind PR
  • aarch64 Fedora Rawhide LTO PR
  • AMD64 Arch Linux Usan PR
  • aarch64 RHEL8 LTO PR
  • AMD64 Arch Linux TraceRefs PR
  • aarch64 Fedora Stable Clang PR
  • aarch64 Ubuntu 22.04 BigMem PR
  • aarch64 CentOS9 LTO + PGO PR
  • aarch64 Fedora Stable LTO + PGO PR
  • aarch64 Fedora Stable PR
  • aarch64 Fedora Rawhide Clang Installed PR
  • aarch64 CentOS9 LTO PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 RHEL8 Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Arch Linux Usan Function PR
  • aarch64 Fedora Rawhide Clang PR
  • aarch64 Android PR
  • aarch64 Fedora Rawhide PR
  • aarch64 CentOS9 Refleaks PR
  • aarch64 RHEL8 PR
  • AMD64 Arch Linux VintageParser PR
  • aarch64 Fedora Stable LTO PR
  • aarch64 Fedora Stable Clang Installed PR
  • aarch64 Fedora Rawhide NoGIL PR
  • aarch64 RHEL8 LTO + PGO PR
  • AMD64 Arch Linux Asan Debug PR
  • aarch64 Fedora Rawhide Refleaks PR
gpshead reacted with laugh emojiencukou reacted with confused emoji

@alex
Copy link
Member

I think this looks right, but I've never actually done the process myself :-)

The only other thing we might want is bumping the version that's used in the Windows and macOS builds.

@ned-deily
Copy link
Member

I believe@gpshead has done these updates most recently.

@ned-deily
Copy link
Member

ned-deily commentedNov 27, 2024•
edited
Loading

The only other thing we might want is bumping the version that's used in the Windows and macOS builds.

Up to now, we've treated that as a separate decision, independent of what version(s) CPython supports. In particular, we have been taking the conservative approach and sticking with OpenSSL 3.0.x which is documented as that project's LTS version. We will eventually have to revisit that, i.e. before 2026-09-07, but it doesn't need to be part of this process.

alex reacted with thumbs up emoji

@gpsheadgpshead self-assigned thisNov 27, 2024
@petermarko
Copy link
Contributor

This does not seem to fix#125936
After picking commit "Generate data for OpenSSL 3.4 and add it to multissltests" to 3.13.0, the test are still failing.
I don't see the afected tests being run inhttps://github.com/python/cpython/actions/runs/12051565064/job/33602924793
Not sure what I'm missing here...

@encukou
Copy link
MemberAuthor

@petermarko, yes, this is better error reporting in general, but doesn't affect the bug we're getting there. I'll send another PR for a better error message for that case, andthen, hopefully, one to fix the underlying bug.

@encukouencukou merged commitdb5c576 intopython:mainNov 28, 2024
41 checks passed
@encukouencukou deleted the make_ssl_data branchNovember 28, 2024 12:29
halstead pushed a commit to yoctoproject/poky that referenced this pull requestNov 29, 2024
python/cpython#127331python/cpython#127361(From OE-Core rev: e271e9cbf896f1fb97d56c426e4217a6d2105ea4)Signed-off-by: Peter Marko <peter.marko@siemens.com>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this pull requestNov 29, 2024
python/cpython#127331python/cpython#127361Signed-off-by: Peter Marko <peter.marko@siemens.com>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to yoctoproject/poky that referenced this pull requestNov 29, 2024
python/cpython#127331python/cpython#127361(From OE-Core rev: e5f3a1793e34fb4cd1e53ca60b67f9a9f084b7a6)Signed-off-by: Peter Marko <peter.marko@siemens.com>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this pull requestNov 29, 2024
python/cpython#127331python/cpython#127361Signed-off-by: Peter Marko <peter.marko@siemens.com>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
leimaohui pushed a commit to ubinux/yocto-ubinux that referenced this pull requestDec 25, 2024
python/cpython#127331python/cpython#127361(From OE-Core rev: e5f3a1793e34fb4cd1e53ca60b67f9a9f084b7a6)Signed-off-by: Peter Marko <peter.marko@siemens.com>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
leimaohui pushed a commit to ubinux/yocto-ubinux that referenced this pull requestDec 25, 2024
python/cpython#127331python/cpython#127361(From OE-Core rev: e5f3a1793e34fb4cd1e53ca60b67f9a9f084b7a6)Signed-off-by: Peter Marko <peter.marko@siemens.com>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
… process (pythonGH-127331)- Add `git describe` output to headers generated by `make_ssl_data.py`  This info is more important than the date when the file was generated.  It does mean that the tool now requires a Git checkout of OpenSSL,  not for example a release tarball.- Regenerate the older file to add the info.  To the other older file, add a note about manual edits.- Add notes on how to add a new OpenSSL version- Add 3.4 error messages and multissl tests
@rossburton
Copy link
Contributor

rossburton commentedApr 30, 2025•
edited
Loading

Any chance of this being backported to the 3.13 branch? As can be seen in the reference list above, Yocto is carrying this patch as we build 3.13 against OpenSSL 3.4.

@encukou
Copy link
MemberAuthor

@Yhg1s Do you want Python 3.13 to have messages for OpenSSL 3.4's new error codes?
I see it as a feature but wouldn't mind doing the backport.

@encukou
Copy link
MemberAuthor

We now have PRs for OpenSSL 3.4.1 (#131618) and 3.5 (#137720). All error messages, plus improvements to the scripts that generate the files.

@Yhg1s, the question still stands. I'm happy to do the backports if you want them.

@Yhg1s
Copy link
Member

Ah, sorry, I thought we'd discussed this (or maybe I just didn't make the final call). No, I don't think we should backport this to 3.13. It may seem harmless but it's the kind of thing that'll trip people up when doing patch upgrades (which we want to be as seamless as possible, evidence of the last couple of expedited releases notwithstanding.)

@encukou
Copy link
MemberAuthor

It's also possible I didn'trecord your call correctly back then.
Thanks for making it clear!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

@gpsheadgpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@encukou@bedevere-bot@alex@ned-deily@petermarko@rossburton@Yhg1s@gpshead
[8]ページ先頭
©2009-2025 Movatter.jp