Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-126883: Add check that timezone fields are in range fordatetime.fromisoformat#127242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pganssle merged 13 commits intopython:mainfromdonBarbos:issue-126883
May 19, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbosdonBarbos commentedNov 25, 2024•
edited by bedevere-appbot
Loading

  1. UpdateC implementation
  2. UpdatePython implementation
  3. Add more use cases to tests

Also error output for thetime.fromisoformat function was fixed as indatetime.fromisoformat in Python implementation

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@pganssle
Copy link
Member

I haven't had a chance for a through review yet, but I'm in favor of the general approach and a casual glance looks good.

Can you add a news blurb (credit yourself appropriately unless you don't want that for some reason), and if you aren't already in ACKS please add yourself there (again unless you don't want to be acknowledged for some reason).

donBarbos reacted with thumbs up emoji

@donBarbos
Copy link
ContributorAuthor

@pganssle done 👍
I think it's now ready for review and merging.
And I'll soon send a PR to solve the rest of the problems described here#127260 and I would be grateful if you answered in the issue.

@donBarbos
Copy link
ContributorAuthor

@erlend-aasland maybe you have free time to review and merge it

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please remove any unneeded style changes?

donBarbos reacted with thumbs up emoji
donBarbosand others added3 commitsFebruary 5, 2025 08:38
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@donBarbos
Copy link
ContributorAuthor

cc@pganssle@erlend-aasland
sorry for another ping but this was one of my first PRs and it's a matter of principle :)

Copy link
Member

@pgansslepganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor nits, but overall looks good!

donBarbos reacted with thumbs up emoji
Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>
@donBarbosdonBarbos requested a review frompganssleMay 19, 2025 16:12
@pgansslepganssle merged commit71c42b7 intopython:mainMay 19, 2025
46 checks passed
@pganssle
Copy link
Member

Thanks@donBarbos, great work on this and sorry for the long delay.

donBarbos reacted with heart emoji

@donBarbos
Copy link
ContributorAuthor

thank you everyone for review

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pgansslepgansslepganssle approved these changes

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aasland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@donBarbos@pganssle@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp