Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-119786: Add jit.md. Move adaptive.md to a section of interpreter.md.#127175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 13 commits intopython:mainfromiritkatriel:adaptive
Dec 6, 2024

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedNov 22, 2024
edited by bedevere-appbot
Loading

@iritkatrieliritkatriel changed the titlegh-119786: add intro to adaptive.md. Update index headingsgh-119786: add intro to adaptive.md. Add tier2.md.Nov 22, 2024
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A lot of the terminology here is confusing, as we haven't put a lot of effort into choosing good names.
I'd suggest using "interpreter" for tier 1 including the specializations and "jit" for tier 2.

This leads to some odd terminology like "jit interpreter" for the tier 2 interpreter, but I think it is clearer overall.

I think a lot of core devs and the wider community think that what we currently call the "jit", i.e. the machine code generation pass, is where the performance gains will come from, but they will come from all of tier 2. The earlier passes will be vital for good performance.

Also, maybe add a diagram like this:faster-cpython/ideas#557 (comment)

@@ -0,0 +1,124 @@
#The Tier 2 Interpreter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is potentially confusing. The tier 2 interpreter is, in my mind, only used to debug tier 2 code. It is the jit-compiled machine code that executes tier 2 normally.

Also, I think we want to move away from "tier 2" and use "JIT". Seefaster-cpython/ideas#614 (comment)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm making this change, but the code does refer to tier 2 in various places so I think it needs to be mentioned, otherwise future devs will be confused.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@iritkatrieliritkatriel changed the titlegh-119786: add intro to adaptive.md. Add tier2.md.gh-119786: Add jit.md. Move adaptive.md to a section of interpreter.md.Dec 5, 2024
@iritkatriel
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-app
Copy link

Thanks for making the requested changes!

@markshannon,@mdboom: please review the changes made to this pull request.

@bedevere-appbedevere-appbot requested a review frommdboomDecember 5, 2024 20:45

###Maintaining stats

Finally, take care that stats are gathered correctly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If we currently have docs about pystats, we may want to link to that here. (If we don't, don't worry about that now...)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know of any.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is excellent, thanks.

I have a few (minor) suggestions, otherwise it looks very good.

iritkatriel reacted with heart emoji
and a`_PyUOpExecutor_Type` is created to contain it.

##Debugging a uop executor in the JIT interpreter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add a sentence or two saying why we have this strange looking interpreter?
Being able to debug and analyze the optimizations prior independent of machine code generation is vey valuable.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One typo to fix, otherwise looks good.

iritkatriel reacted with hooray emoji
iritkatrieland others added2 commitsDecember 6, 2024 16:28
Co-authored-by: Mark Shannon <mark@hotpy.org>
@iritkatrieliritkatriel merged commit89fa7ec intopython:mainDec 6, 2024
23 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments

@mdboommdboommdboom approved these changes

@markshannonmarkshannonmarkshannon approved these changes

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel@mdboom@markshannon@brandtbucher

[8]ページ先頭

©2009-2025 Movatter.jp