Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
GH-126795: Increase the JIT side-exit threshold from 64 to 4096#127155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
brandtbucher commentedNov 22, 2024
Results across platforms. Very similar toGH-126816, in that it looks like the memory savings are more pronounced on AArch64 macOS and the performance impact is more pronounced on AArch64 Linux.
Another nice win for Arm,@diegorusso. :) |
94b8f8b intopython:main 48 of 49 checks passed
Uh oh!
There was an error while loading.Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
3.14bugs and security fixes interpreter-core(Objects, Python, Grammar, and Parser dirs) performancePerformance or resource usage skip newstopic-JIT
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This should be covered by the NEWS entry inGH-126816. Looks like a ~0.5% speedup and ~0.5% memory savings, so nothing too dramatic there. Only 1/3 as many traces created though, with no change to the number of uops executed, so the memory and time we're saving does seem like it's completely wasted currently (stats).
I'm running benchmarks across all platforms now.