Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-122273: Support PyREPL history on Windows#127141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-Authored-By: devdanzin <74280297+devdanzin@users.noreply.github.com>
vstinner commentedNov 22, 2024
| exceptImportError: | ||
| readline=None | ||
| else: | ||
| importrlcompleter# noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can this import ever fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't know. In case of doubt, I prefer to keep the old behavior: catch and ignore ImportError.
ambv left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tested on Windows 11 with PowerShell and cmd.exe, works as intended.
3c7a90a intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry,@vstinner, I could not cleanly backport this to |
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>(cherry picked from commit3c7a90a)
GH-127289 is a backport of this pull request to the3.13 branch. |
vstinner commentedNov 26, 2024
Merged, thanks for the review@ambv. |
bedevere-bot commentedNov 26, 2024
|
vstinner commentedNov 26, 2024
|
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.