Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-122273: Support PyREPL history on Windows#127141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:pyrepl_history_win
Nov 26, 2024

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedNov 22, 2024
edited by bedevere-appbot
Loading

Co-Authored-By: devdanzin <74280297+devdanzin@users.noreply.github.com>
@vstinner
Copy link
MemberAuthor

exceptImportError:
readline=None
else:
importrlcompleter# noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can this import ever fail?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know. In case of doubt, I prefer to keep the old behavior: catch and ignore ImportError.

Copy link
Contributor

@ambvambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested on Windows 11 with PowerShell and cmd.exe, works as intended.

vstinner reacted with thumbs up emoji
@vstinnervstinner merged commit3c7a90a intopython:mainNov 26, 2024
52 checks passed
@miss-islington-app
Copy link

Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@vstinner, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 3c7a90a83146dc6e55f6f9ecd9af0bf9682f98a6 3.13

@vstinnervstinner deleted the pyrepl_history_win branchNovember 26, 2024 09:22
vstinner added a commit to vstinner/cpython that referenced this pull requestNov 26, 2024
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>(cherry picked from commit3c7a90a)
@bedevere-app
Copy link

GH-127289 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 26, 2024
@vstinner
Copy link
MemberAuthor

Merged, thanks for the review@ambv.

vstinner added a commit that referenced this pull requestNov 26, 2024
gh-122273: Support PyREPL history on Windows (#127141)Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>(cherry picked from commit3c7a90a)
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotx86-64 MacOS Intel NoGIL 3.13 has failed when building commita5741d6.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1449/builds/713) and take a look at the build logs.
  4. Check if the failure is related to this commit (a5741d6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1449/builds/713

Failed tests:

  • test_threading

Failed subtests:

  • test_start_new_thread_failed - test.test_threading.ThreadTests.test_start_new_thread_failed

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-intel-aws.nogil/build/Lib/test/test_threading.py", line1205, intest_start_new_thread_failedself.assertEqual(out,b'ok')~~~~~~~~~~~~~~~~^^^^^^^^^^^^AssertionError:b"skip\nshouldn't be printed" != b'ok'

@vstinner
Copy link
MemberAuthor

test_start_new_thread_failed - test.test_threading.ThreadTests.test_start_new_thread_failed

#109761 (comment)

ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ambvambvambv approved these changes

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees

@vstinnervstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@bedevere-bot@ambv

[8]ページ先頭

©2009-2025 Movatter.jp