Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-114940: Add _Py_FOR_EACH_TSTATE_UNLOCKED(), and Friends#127077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedNov 20, 2024•
edited
Loading

This is a precursor to the actual fix forgh-114940, where we will change these macros to use the new lock. This change is almost entirely mechanical; the exceptions are the loops in codeobject.c and ceval.c, which now hold the "head" lock. Note that almost all of the uses of_Py_FOR_EACH_TSTATE_UNLOCKED() here will change to_Py_FOR_EACH_TSTATE_BEGIN() once we add the new per-interpreter lock.

@ericsnowcurrently
Copy link
MemberAuthor

@colesbury, do you have any objections to how I turn_Py_FOR_EACH_THREAD() into_Py_FOR_EACH_STW_INTERP() in pystate.c? Again, it's a fairly mechanical change, but it will allow us to more easily switch to the per-interpreter lock in a follow-up PR.

@colesbury
Copy link
Contributor

No objections from me!

ericsnowcurrently reacted with thumbs up emoji

@ericsnowcurrentlyericsnowcurrently merged commit9dabace intopython:mainNov 21, 2024
37 checks passed
@ericsnowcurrentlyericsnowcurrently deleted the fix-tstates-iteration branchNovember 21, 2024 18:08
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
…hongh-127077)This is a precursor to the actual fix forpythongh-114940, where we will change these macros to use the new lock.  This change is almost entirely mechanical; the exceptions are the loops in codeobject.c and ceval.c, which now hold the "head" lock.  Note that almost all of the uses of _Py_FOR_EACH_TSTATE_UNLOCKED() here will change to _Py_FOR_EACH_TSTATE_BEGIN() once we add the new per-interpreter lock.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ericsnowcurrently@colesbury
[8]ページ先頭
©2009-2025 Movatter.jp