Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-126618: fix repr(itertools.count(sys.maxsize))#127048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromskirpichev:fix-count-repr-126618
Dec 2, 2024

Conversation

@skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedNov 20, 2024•
edited by bedevere-appbot
Loading

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@skirpichev
Copy link
ContributorAuthor

cc@vstinner (as this also include reversion of#126617)

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I assume that you picked up my tests and NEWS entry so it should be fine.

@skirpichev
Copy link
ContributorAuthor

Yes. And tests from#126617 aren't reverted, of course.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vstinnervstinner merged commit930ba0c intopython:mainDec 2, 2024
49 checks passed
@vstinnervstinner added the needs backport to 3.13bugs and security fixes labelDec 2, 2024
@miss-islington-app
Copy link

Thanks@skirpichev for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 2, 2024
)(cherry picked from commit930ba0c)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-127508 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelDec 2, 2024
@vstinnervstinner added the needs backport to 3.12only security fixes labelDec 2, 2024
@miss-islington-app
Copy link

Thanks@skirpichev for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@skirpichev and@vstinner, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 930ba0ce605eee9e3b992fa368b00a3f2b7dc4c1 3.12

@vstinner
Copy link
Member

@skirpichev@picnixz: Does the 3.12 branch have the bug? If yes, can you propose a backport@skirpichev?

@picnixz
Copy link
Member

I think so. The reason why I didn't put the 3.12 label before was because my branch used free-threaded special code. This fix is 3.12+ compatible (the fix that was reverted in this PR was backported up to 3.12).

@skirpichevskirpichev deleted the fix-count-repr-126618 branchDecember 2, 2024 13:26
@skirpichev
Copy link
ContributorAuthor

I'm working on backport.

vstinner reacted with thumbs up emoji

vstinner pushed a commit that referenced this pull requestDec 2, 2024
…127508)gh-126618: fix repr(itertools.count(sys.maxsize)) (GH-127048)(cherry picked from commit930ba0c)Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-127510 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 2, 2024
vstinner pushed a commit that referenced this pull requestDec 2, 2024
…127510)(cherry picked from commit930ba0c)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@picnixzpicnixzpicnixz approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

+1 more reviewer

@Redeyder723Redeyder723Redeyder723 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vstinnervstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@vstinner@picnixz@Redeyder723
[8]ページ先頭
©2009-2025 Movatter.jp