Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-114940: Add a Per-Interpreter Lock For the List of Thread States#127037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| HEAD_LOCK(runtime); | ||
| if (runtime->stoptheworld.requested) { | ||
| decrement_stoptheworld_countdown(&runtime->stoptheworld); | ||
| } | ||
| HEAD_UNLOCK(runtime); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is correct, but need to double-check.
Uh oh!
There was an error while loading.Please reload this page.
It seems that there is an error in CI, I will refer to your implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If I remember correctly, this was an issue that could not be changed because it would cause unexpected issues with CI (it was originally changed in my PR)
I have factored outgh-127077 and will later update this PR on top of it. |
Uh oh!
There was an error while loading.Please reload this page.
The new lock may be used instead of the global "HEAD" lock. That global lock guards the list of interpreters, but unfortunately also gets used as a generic "lock everything". This change helps us move away from that situation.
FYI, this is very similar togh-125561.