Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-126911: Update credits output#126913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 6 commits intopython:mainfromStanFromIreland:patch-1
Nov 18, 2024
Merged

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedNov 16, 2024•
edited by bedevere-appbot
Loading

Trivial change updating name of Python Foundation.

@ghost
Copy link

ghost commentedNov 16, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@hugovk
Copy link
Member

Thanks for the suggestion, but I don't think we should erase their contribution and credit because they had dot com in their name, and the corresponding website is no longer up.

BeOpen.com also has history relating to licensing:

https://docs.python.org/3/license.html

Trivial change updating name of Python Foundation.

See the history page above, the PSF isn't the same as BeOpen.com with a new name.

@hugovkhugovk added the pendingThe issue will be closed if no feedback is provided labelNov 16, 2024
@StanFromIreland
Copy link
MemberAuthor

@hugovk

My mistake I have updated my commit to include BeOpen.

Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approve with 2 tweaks.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@terryjreedyterryjreedy changed the titlegh-126911: Update credits output (Trivial Change)gh-126911: Update credits outputNov 17, 2024
@terryjreedyterryjreedy added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsNov 17, 2024
@terryjreedy
Copy link
Member

Hugo: I am not sure whether changing 'BeOpen.com' to 'BeOpen' is proper or whether '.com' is part of the name, as opposes to url. Even if '.com' was part of the name, the fact that 'BeOpen.com' in the browser resolves to now unrelated 'beopen.com' suggest that deleteing '.com' is a good idea. I am letting you decide and merge.

Stan: the commit message one adds is intended to be put above, not below, the boilerplate comment. Much easier to edit when above.

encukou, hugovk, and StanFromIreland reacted with thumbs up emoji

@hugovkhugovk removed the pendingThe issue will be closed if no feedback is provided labelNov 18, 2024
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As far as I can tell, "BeOpen.com" was the full name. It was from the dotcom bubble days, and they've long been out of business (as is visible from the new owners of the domain).

We should keep "BeOpen.com" for thecopyright andlicence, but I thinks it's fine to use a shorter version here in the REPL credits.

@hugovk
Copy link
Member

@StanFromIreland Tip for next time, we prefer not to rebase branches and force push in this repo, thanks!

@hugovkhugovk merged commit8fe1926 intopython:mainNov 18, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks@StanFromIreland for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 18, 2024
(cherry picked from commit8fe1926)Co-authored-by: Stan U. <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-126973 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 18, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 18, 2024
(cherry picked from commit8fe1926)Co-authored-by: Stan U. <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-126974 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 18, 2024
@StanFromIrelandStanFromIreland deleted the patch-1 branchNovember 18, 2024 15:31
hugovk added a commit that referenced this pull requestNov 18, 2024
Co-authored-by: Stan U <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull requestNov 18, 2024
Co-authored-by: Stan U <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@encukouencukouencukou left review comments

@hugovkhugovkhugovk approved these changes

@terryjreedyterryjreedyterryjreedy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@hugovk@terryjreedy@encukou
[8]ページ先頭
©2009-2025 Movatter.jp