Nov 20, 2024 · Oct 15, 2024 · Nov 7, 2024 · Nov 16, 2024 · Nov 19, 2024 · Nov 19, 2024
diff --git a/Lib/test/support/strace_helper.py b/Lib/test/support/strace_helper.py
        res, cmd_line = run_python_until_end(
            "-c",
            textwrap.dedent(code),
            __run_using_command=[_strace_binary] + strace_flags)
            __run_using_command=[_strace_binary] + strace_flags,
            # Don't want to trace our JIT's own mmap and mprotect calls:
            PYTHON_JIT="0",
        )
    except OSError as err:
        return _make_error("Caught OSError", err)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -91,7 +91,10 @@ def _make_error(reason, details):
		res, cmd_line = run_python_until_end(
		"-c",
		textwrap.dedent(code),
		__run_using_command=[_strace_binary] + strace_flags)
		__run_using_command=[_strace_binary] + strace_flags,
		# Don't want to trace our JIT's own mmap and mprotect calls:
		PYTHON_JIT="0",
Copy link Contributor cmaloneyNov 20, 2024• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Guessing this showed up in the`test_fileio` test`test_syscalls_read`? I have been keeping an eye on / working through a couple other issues where mmap(NULL) and mprotect show up, trying to figure out if just excluding those two from that test would be good/effective (memory allocation happening in reading files is fine / not what the test is focused on). Copy link MemberAuthor brandtbucherNov 21, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Yeah, I was wondering if this was susceptible to catching badly-timed arena allocations and such too. Might make sense to have an option to ignore the`mmap`/`munmap`/`mprotect` family of functions instead of this ad-hoc fix. I'm just not familiar with how this is being used, and didn't want to change the meaning/behavior of the tests too dramatically. cmaloney reacted with thumbs up emoji
		)
		except OSError as err:
		return _make_error("Caught OSError", err)

Expand Down