Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
[3.12] gh-71936: Fix race condition in multiprocessing.Pool (GH-124973)#126870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…124973)*pythongh-71936: Fix race condition in multiprocessing.PoolProxes of shared objects register a Finalizer in BaseProxy._incref(), and itwill call BaseProxy._decref() when it is GCed. This may cause a race conditionwith Pool(maxtasksperchild=None) on Windows.A connection would be closed and raised TypeError when a GC occurs between_ConnectionBase._check_writable() and _ConnectionBase._send_bytes() in_ConnectionBase.send() in the second or later task, and a new objectis allocated that shares the id() of a previously deleted one.Instead of using the id() of the token (or the proxy), use a unique,non-reusable number.(cherry picked from commitba088c8)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-Authored-By: Akinori Hattori <hattya@gmail.com>
d0d892f intopython:3.12 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxes of shared objects register a Finalizer in BaseProxy._incref(), and it
will call BaseProxy._decref() when it is GCed. This may cause a race condition
with Pool(maxtasksperchild=None) on Windows.
A connection would be closed and raised TypeError when a GC occurs between
_ConnectionBase._check_writable() and _ConnectionBase._send_bytes() in
_ConnectionBase.send() in the second or later task, and a new object
is allocated that shares the id() of a previously deleted one.
Instead of using the id() of the token (or the proxy), use a unique,
non-reusable number.
(cherry picked from commitba088c8)
Co-authored-by: Petr Viktorinencukou@gmail.com
Co-Authored-By: Akinori Hattorihattya@gmail.com