NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.12] gh-126807: pygettext: Do not attempt to extract messages from function definitions. (GH-126808)#126847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 1 commit intopython:3.12frommiss-islington:backport-9a45638-3.12

Nov 14, 2024

Merged

[3.12] gh-126807: pygettext: Do not attempt to extract messages from function definitions. (GH-126808)#126847

serhiy-storchaka merged 1 commit intopython:3.12frommiss-islington:backport-9a45638-3.12

Nov 14, 2024

Conversation

Copy link

Contributor

miss-islington commentedNov 14, 2024•
edited by bedevere-appbot
Loading

Fixes a bug where pygettext would attempt
to extract a message from a code like this:

def _(x): pass

This is because pygettext only looks at one
token at a time and '_(x)' looks like a
function call.

However, since 'x' is not a string literal,
it would erroneously issue a warning.
(cherry picked from commit9a45638)

Co-authored-by: Tomas R.tomas.roun8@gmail.com

Issue:pygettext: false positives when extracting messages #126807

pythongh-126807: pygettext: Do not attempt to extract messages from f…

d148407

…unction definitions. (pythonGH-126808)Fixes a bug where pygettext would attemptto extract a message from a code like this:def _(x): passThis is because pygettext only looks at onetoken at a time and '_(x)' looks like afunction call.However, since 'x' is not a string literal,it would erroneously issue a warning.(cherry picked from commit9a45638)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>