Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-126654: Fix crash in several functions in_interpreters module#126678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 1 commit intopython:mainfromsobolevn:issue-126654
Nov 11, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedNov 11, 2024
edited by bedevere-appbot
Loading

This was the cause:

  • We checked that passed arg is not adict here:
    if (!PyDict_CheckExact(nsobj)) {
    PyErr_SetString(PyExc_TypeError,"expected a dict");
    returnNULL;
    }
  • Later we had an assertion about!PyErr_Occurred()

So, I went with the early validation.

@kumaraditya303kumaraditya303 added the needs backport to 3.13bugs and security fixes labelNov 11, 2024
@kumaraditya303kumaraditya303 merged commit9fc2808 intopython:mainNov 11, 2024
47 checks passed
@miss-islington-app
Copy link

Thanks@sobolevn for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 11, 2024
…dule (pythonGH-126678)(cherry picked from commit9fc2808)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-126681 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 11, 2024
kumaraditya303 pushed a commit that referenced this pull requestNov 11, 2024
…odule (GH-126678) (#126681)gh-126654: Fix crash in several functions in `_interpreters` module (GH-126678)(cherry picked from commit9fc2808)Co-authored-by: sobolevn <mail@sobolevn.me>
picnixz pushed a commit to picnixz/cpython that referenced this pull requestDec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@kumaraditya303

[8]ページ先頭

©2009-2025 Movatter.jp