And some error codes are missing in the document. I'll finish them tomorrow.

@rruuaanng Please don't edit out theIssue: section that the bot adds.

Sorry, I didn't seem to pay attention.

Sorry, I didn't seem to pay attention.

You've been toldmultiple times to read the devguide;please pay attention and do so. It is clear from your pattern of behaviour that you do not have a clear concept of our development workflow. Please focus on the first section,Getting Started.

https://devguide.python.org

And some error codes are missing in the document. I'll finish them tomorrow.

This is why you shouldtest your changes locally before creating a PR. Please read the devguide.

And some error codes are missing in the document. I'll finish them tomorrow.

This is why you shouldtest your changes locally before creating a PR. Please read the devguide.

It refers to my other PR.

Please add this change to#126420.

Please add this change to#126420.

No problem. I think it might be better this way.

Please add this change to#126420.

Ah, this actually adds a new constant. Then it does not belong to thedocumentation issue you've linked this to. Please see if there is an open issue; if not, create an issue for this.

Please add this change to#126420.

Ah, this actually adds a new constant. Then it does not belong to thedocumentation issue you've linked this to. Please see if there is an open issue; if not, create an issue for this.

It's issue is what the PR title point to. If you don't mind, you can help me reopen this PR first and then let me do other work :)

No, it is not. The issue is about missing documentation, not missing code. There is a big difference! Missing documentation would be a bug in the documentation, so any linked PRs would be backported to all supported branches. On the other side, missing error codes arenew features; they cannot be backported! Please understand this. This is explained in the devguide;please read it!

Please do not reopen this PR;focus only on your existing PRs before openingany new PR at all.

Oh, I apologize. My thought is that new content should be reviewed separately from documentation changes. Thank you for your attention to this!

My thought is that new content should be reviewed separately from documentation changes. Thank you for your attention to this!

That is a correct assumption, but they are (mostly) also separated by issue. The general idea is that you should think ofissues like you would think ofGood Commits (devguide-link; please read it!): don't mix features and bug-fixes in the same issue (and definitely not in a commit).

Again, I urge you to focus only on your currently open PRs. Try not to lose focus by opening new PRs/issues nor by reviewing other work. I think you will learn more and be more successful by being more focused (and I also think this will greatly reduce reviewer friction). Please consider my advice.

Erlend, thank you so much. It seems like most of my PRs have been reviewed by you. I know you've mentioned these points many times, and I apologize for that. I really have been reading the development guidelines, but sometimes I might not notice when I violate them, which stems from my mindset being stuck in another development mode (in fact, I didn't even know what CI was at first). If I violate the development rules again while working on other PRs, I hope you can remind me! In the future, I will focus on completing the PRs I open, and although I may spend some time helping others or reviewing, it won't detract from my commitment to my own PRs. Thank you for taking the time to guide me. I really appreciate it!

I really have been reading the development guidelines, but sometimes I might not notice when I violate them, which stems from my mindset being stuck in another development mode [...]

This is why I'm suggesting that you focus on your open PRs. You will learn better by focusing your efforts. Remember also that landing a PR can be time-consuming. It may take several months in some cases! Also remember that it is ok for PRs to be rejected; that happens all the time, so do not take it personally.

[...] although I may spend some time helping others or reviewing, it won't detract from my commitment to my own PRs [...]

I will advice you again from doing this; after resolving your open PRs, you can try again to perform a couple of reviews, but I would rather not encourage you to learn these two development workflows at the same time. Please consider my advice.

If I violate the development rules again while working on other PRs, I hope you can remind me!

It is ok to forget things, especially for early contributors, but the repeated patterns of not following our development workflow indicates that more time needs to be spent with the devguide before continuing your contributions. This is perfectly fine. I do not expect you to know the entire devguide by heart (none of us do!),but I do expect you to read the sections I link to and learn from your failures. I know I'm very direct with you, but it is with the best intentions.

@erlend-aasland here :)

I should probably open a new PR.