Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14#126392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromhugovk:docs-co_lnotab-3.15
Nov 4, 2024

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedNov 4, 2024•
edited by bedevere-appbot
Loading

There's still quite a bit of usein the wild and we're in no rush to remove this in Python 3.14.

Let's bump to 3.15 and reassess during the next cycle.

📚 Documentation preview 📚:https://cpython-previews--126392.org.readthedocs.build/

@hugovkhugovk added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsNov 4, 2024
@bedevere-appbedevere-appbot added docsDocumentation in the Doc dir skip news awaiting core review labelsNov 4, 2024
@hugovkhugovk changed the titlegh-101866: Docs: Keep co_lnotab deprecation for at least 3.14gh-101865: Docs: Keep co_lnotab deprecation for at least 3.14Nov 4, 2024
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's unlikely this will be removed while it's still in use bypytorch,huggingface, and many others. So I'd also be okay with changing the deprecation notice to an undefined removal date for now. But at the same time, it's less likely that they'll ever remove their uses ofco_lnotab unless thereis a removal date, so this is also fine!

hugovk and encukou reacted with thumbs up emoji
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@encukou
Copy link
Member

Why not “maybe someday” rather than 3.15? To me it seems that not breaking things would save effort on both sides.

@markshannon
Copy link
Member

While we could delay this indefinitely, we should encourage users to move as sooner rather than later.

Usingco_lnotab for picking is pointless asco_linetable contains all the information.
If it is being used to find line numbers, it is far more efficient to useco_lines orco_positions.

sobolevn, willingc, and hugovk reacted with thumbs up emoji

Copy link
Contributor

@willingcwillingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good@hugovk. Thanks.

@hugovk
Copy link
MemberAuthor

And I the wording is now all "May be removed in ..." instead of 2x that and 1x "therefore it will be removed in ..."

@hugovkhugovk merged commiteac41c5 intopython:mainNov 4, 2024
40 checks passed
@hugovkhugovk deleted the docs-co_lnotab-3.15 branchNovember 4, 2024 16:50
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker eac41c5ddfadf52fbd84ee898ad56aedd5d90a41 3.13

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker eac41c5ddfadf52fbd84ee898ad56aedd5d90a41 3.12

hugovk added a commit to hugovk/cpython that referenced this pull requestNov 4, 2024
… 3.14 (pythonGH-126392)(cherry picked from commiteac41c5)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-126403 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelNov 4, 2024
hugovk added a commit to hugovk/cpython that referenced this pull requestNov 4, 2024
… 3.14 (pythonGH-126392)(cherry picked from commiteac41c5)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-126404 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@willingcwillingcwillingc approved these changes

@sobolevnsobolevnsobolevn approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@hugovkhugovk

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@hugovk@encukou@markshannon@willingc@sobolevn@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp