Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-126366: Fix crash if__iter__ raises an exception duringyield from#126369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commentedNov 3, 2024
edited
Loading

Apparently,gh-126366 has two issues: one is a thread safety problem insidelist.__init__, and then the other is that theGET_YIELD_FROM_ITER instruction crashes if a non-native-generator object raises an exception in its__iter__. Since the latter only applies to 3.14, I'm splitting the fix into two PRs.

@ZeroIntensity
Copy link
MemberAuthor

I don't understand how the JIT failures could be related.

@ZeroIntensity
Copy link
MemberAuthor

@savannahostrowski@diegorusso My JIT experts, are these known failures, or is there something wrong with my fix?

@savannahostrowski
Copy link
Member

savannahostrowski commentedNov 3, 2024
edited
Loading

@ZeroIntensity The aarch64 failures are known/expected. This is what we were discussing over Discord a couple of days back. Right now, we are waiting for this to be fixed in the aarch64 macos runners.

As for the emulated Linux failures, sometimes we do see failures here, and that's why we maintainthis list of tests to skip. I will note that this test was seen recently passing inhttps://github.com/python/cpython/actions/runs/11647994504/job/32434030552?pr=126339).

If this PR has nothing to do withtest.test_subprocess.POSIXProcessTestCase.test_vfork_used_when_expected (and I suspect it doesn't...), it may need to be added to the skip list.

diegorusso reacted with thumbs up emoji

@ZeroIntensity
Copy link
MemberAuthor

Thank you, Savannah! I'll update the skip list and see if that fixes it.

savannahostrowski reacted with heart emoji

Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@kumaraditya303kumaraditya303 merged commit1371295 intopython:mainNov 5, 2024
65 of 67 checks passed
@vstinner
Copy link
Member

Would it be possible to backport the test to 3.12 and 3.13?

@ZeroIntensity
Copy link
MemberAuthor

Maybe, but would it be all that useful? Anything that gets backported to those versions will (probably) have to go through the test on main anyway.

@vstinner
Copy link
Member

It's useful to check for non-regression: make sure that we don't break this code path in the future.

ZeroIntensity reacted with thumbs up emoji

picnixz pushed a commit to picnixz/cpython that referenced this pull requestDec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes

@brandtbucherbrandtbucherbrandtbucher approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZeroIntensity@savannahostrowski@vstinner@colesbury@brandtbucher@kumaraditya303

[8]ページ先頭

©2009-2025 Movatter.jp