Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-126138: Fix UAF in asyncio.Task when task calls back to user definedcancel function#126305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Nico-Posada commentedNov 1, 2024
Oh it seems I pulled in my change from#126230 too, don't think it'll cause any issues though. Can remove if needed. |
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the patch Nico! I gave you some suggestions for the comments but feel free to change where the line ends (hard to see where the 80-chars limit lie on GH Web UI).
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Library/2024-11-01-14-31-41.gh-issue-126138.yTniOG.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
f032f6b intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@Nico-Posada for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…attribute__` (pythonGH-126305)(cherry picked from commitf032f6b)Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
…attribute__` (pythonGH-126305)(cherry picked from commitf032f6b)Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
GH-126324 is a backport of this pull request to the3.13 branch. |
GH-126325 is a backport of this pull request to the3.12 branch. |
…attribute__` (python#126305)Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
…attribute__` (python#126305)Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Uh oh!
There was an error while loading.Please reload this page.
No test cases because of how similar this is to#126120, but can add if needed. Blurb definitely needs some revision too because I'm bad at explaining things sometimes.
__getattribute__when calling a class'scancelfunction intask_step_handle_result_implin_asynciomodule.c#126138