Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-126220: Fix crash on calls to_lsprof.Profiler methods with 0 args (backportable)#126271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
_lsprof.Profiler methods with 0 args_lsprof.Profiler methods with 0 args (backportable)picnixz commentedNov 1, 2024
I'm changing the title of the PR just so that we don't have two PRs that look exactly the same on the issue. |
Misc/NEWS.d/next/Library/2024-10-31-14-06-28.gh-issue-126220.uJAJCU.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
erlend-aasland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(BTW,PyErr_Format always returnsNULL)
…JAJCU.rstCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
28b148f intopython:mainUh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
…h 0 args (backportable) (pythonGH-126271)(cherry picked from commit28b148f)Co-authored-by: sobolevn <mail@sobolevn.me>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
…h 0 args (backportable) (pythonGH-126271)(cherry picked from commit28b148f)Co-authored-by: sobolevn <mail@sobolevn.me>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
GH-126310 is a backport of this pull request to the3.13 branch. |
GH-126311 is a backport of this pull request to the3.12 branch. |
sobolevn commentedNov 1, 2024
Thank you! I will backport this change and go back to the original PR soon :) |
erlend-aasland commentedNov 1, 2024
Next time, remember to edit such a change out of the squashed commit title ;) |
erlend-aasland commentedNov 1, 2024
Nit: ideally, the other PR would have received the title change (adapt to Argument Clinic ...), not this one. |
…h 0 args (backportable) (python#126271)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
…h 0 args (backportable) (python#126271)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Uh oh!
There was an error while loading.Please reload this page.
This is the fix with no AC that we can backport.
#126233 will be reworked to only apply AC to already fixed functions. I plan to merge this one first and then rebase the oirginal one.
_lsprof.Profiler._creturn_callback()segfaults #126220