Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-103951: enable optimization for fast attribute access on module subclasses#126264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ule subclassesThis patch relax specialization requirements from``PyModule_CheckExact(op)`` to``Py_TYPE(op)->tp_getattro != PyModule_Type.tp_getattro``.Benchmarks:```pyimport pyperfimport bimport crunner = pyperf.Runner()runner.timeit('b.x', 'b.x', globals=globals())runner.timeit('c.x', 'c.x', globals=globals())``````pyx = 1``````pyimport sys, typesx = 1class _Foo(types.ModuleType): passsys.modules[__name__].__class__ = _Foo```On the main:```$ python a.py -qb.x: Mean +- std dev: 50.2 ns +- 2.7 nsc.x: Mean +- std dev: 132 ns +- 7 ns```With the patch:```$ python a.py -qb.x: Mean +- std dev: 52.9 ns +- 3.6 nsc.x: Mean +- std dev: 52.6 ns +- 2.7 ns```Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk> This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Uh oh!
There was an error while loading.Please reload this page.
Fidget-Spinner approved these changesNov 7, 2024
Thanks for the PR@skirpichev |
@skirpichev do you have commit rights? |
@Fidget-Spinner, no. I'm just member of Python triage team. |
d9e2512 intopython:main 61 checks passed
Uh oh!
There was an error while loading.Please reload this page.
picnixz pushed a commit to picnixz/cpython that referenced this pull requestDec 8, 2024
…ule subclasses (pythonGH-126264)Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
…ule subclasses (pythonGH-126264)Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This patch relax specialization requirements from
PyModule_CheckExact(op)toPy_TYPE(op)->tp_getattro != PyModule_Type.tp_getattro.Benchmarks:
On the main:
With the patch: