Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
GH-126212: Fix removal of slashes in file URIs on Windows#126214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Adjust `urllib.request.pathname2url()` and `url2pathname()` so that theydon't remove slashes from Windows DOS drive paths and URLs. There was nobasis for this behaviour, and it conflicts with how UNC and POSIX paths arehandled.
Uh oh!
There was an error while loading.Please reload this page.
barneygale commentedNov 4, 2024
Hey@zooba, hope I'm not being rude with the ping, just wondering if you intend to review again? If so I'm happy to wait! Thanks |
zooba commentedNov 8, 2024
It's not rude, but it's also not helpful :) Pings don't reach me any quicker than regular notifications. This looks good to me. Thanks! |
barneygale commentedNov 8, 2024
Thanks for the review! I pinged because you approved a closely-related PR at the same time, and I thought there might have been a mix-up between the two as you were so quick to reply initially. My mistake - I'm sorry for the noise. And thanks again. |
54c63a3 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…onGH-126214)Adjust `urllib.request.pathname2url()` and `url2pathname()` so that theydon't remove slashes from Windows DOS drive paths and URLs. There was nobasis for this behaviour, and it conflicts with how UNC and POSIX paths arehandled.(cherry picked from commit54c63a3)Co-authored-by: Barney Gale <barney.gale@gmail.com>
GH-126590 is a backport of this pull request to the3.13 branch. |
…onGH-126214)Adjust `urllib.request.pathname2url()` and `url2pathname()` so that theydon't remove slashes from Windows DOS drive paths and URLs. There was nobasis for this behaviour, and it conflicts with how UNC and POSIX paths arehandled.(cherry picked from commit54c63a3)Co-authored-by: Barney Gale <barney.gale@gmail.com>
GH-126591 is a backport of this pull request to the3.12 branch. |
…126214) (#126591)GH-126212: Fix removal of slashes in file URIs on Windows (GH-126214)Adjust `urllib.request.pathname2url()` and `url2pathname()` so that theydon't remove slashes from Windows DOS drive paths and URLs. There was nobasis for this behaviour, and it conflicts with how UNC and POSIX paths arehandled.(cherry picked from commit54c63a3)Co-authored-by: Barney Gale <barney.gale@gmail.com>
…126214) (#126590)GH-126212: Fix removal of slashes in file URIs on Windows (GH-126214)Adjust `urllib.request.pathname2url()` and `url2pathname()` so that theydon't remove slashes from Windows DOS drive paths and URLs. There was nobasis for this behaviour, and it conflicts with how UNC and POSIX paths arehandled.(cherry picked from commit54c63a3)Co-authored-by: Barney Gale <barney.gale@gmail.com>
…on#126214)Adjust `urllib.request.pathname2url()` and `url2pathname()` so that theydon't remove slashes from Windows DOS drive paths and URLs. There was nobasis for this behaviour, and it conflicts with how UNC and POSIX paths arehandled.
…on#126214)Adjust `urllib.request.pathname2url()` and `url2pathname()` so that theydon't remove slashes from Windows DOS drive paths and URLs. There was nobasis for this behaviour, and it conflicts with how UNC and POSIX paths arehandled.
Uh oh!
There was an error while loading.Please reload this page.
Adjust
urllib.request.pathname2url()andurl2pathname()so that they don't remove slashes from Windows DOS drive paths and URLs. There was no basis for this behaviour, and it conflicts with how UNC and POSIX paths are handled.