Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-125028: Prohibit placeholders in partial keywords#126062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

dg-pb
Copy link
Contributor

@dg-pbdg-pb commentedOct 28, 2024•
edited
Loading

@dg-pbdg-pb marked this pull request as draftOctober 30, 2024 08:59
@dg-pbdg-pb marked this pull request as ready for reviewOctober 30, 2024 10:16
dg-pband others added2 commitsJanuary 5, 2025 10:03
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
dg-pband others added2 commitsJanuary 5, 2025 14:56
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please amendDoc/library/functools.rst andDoc/whatsnew/3.14.rst as needed.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@dg-pb
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@erlend-aasland
Copy link
Contributor

Thanks, looks good to me. I'd like Serhiy's eyes on it also.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@dg-pb
Copy link
ContributorAuthor

@rhettinger,@serhiy-storchaka
This is API adjustment for new feature, thus I think it would be good to merge this before 3.14 release. Given it is a fairly small one, maybe it would be good to get it out of the way sooner than later?

Also, what are your thoughts on:

  1. gh-119109: improvefunctools.partial vectorcall with keywords #124584 - in addition to intended improvements this one solves current free-threading issue (the last one in that series) -Race betweenpartial_vectorcall_fallback and_PyVectorcall_FunctionInline under free-threading #128050
  2. gh-124652: partialmethod simplifications #124788 - this one would simplify some complexity ininspect and makepartialmethod a bit more performant

Should either of the above be aimed to be merged before 3.14 or is it not of importance?

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

It should go in 3.14, no question. It is much easier to prohibit this in 3.14, that in any following version, when we would need to pass through a deprecation process. On other hand, we can allow Placeholder as a keyword argument at any time if it is needed.

dg-pb reacted with thumbs up emoji
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
@serhiy-storchakaserhiy-storchaka merged commitafed5f8 intopython:mainMay 8, 2025
43 checks passed
@miss-islington-app
Copy link

Thanks@dg-pb for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 8, 2025
…126062)(cherry picked from commitafed5f8)Co-authored-by: dgpb <3577712+dg-pb@users.noreply.github.com>
@bedevere-app
Copy link

GH-133645 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 8, 2025
serhiy-storchaka pushed a commit that referenced this pull requestMay 8, 2025
… (GH-133645)(cherry picked from commitafed5f8)Co-authored-by: dgpb <3577712+dg-pb@users.noreply.github.com>
@dg-pbdg-pb deleted the gh-125028-prohibit-kw-placeholders branchMay 8, 2025 11:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zhangyx1998zhangyx1998zhangyx1998 left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@dg-pb@erlend-aasland@serhiy-storchaka@zhangyx1998
[8]ページ先頭
©2009-2025 Movatter.jp