Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-126012: Add__class_getitem__ tomemoryview#126013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@brianschubert
Copy link
Member

@brianschubertbrianschubert commentedOct 26, 2024•
edited by github-actionsbot
Loading

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Small nitpicks. We should also add someversionchanged for memoryview objects saying that they are now generics.

brianschubertand others added3 commitsOctober 26, 2024 14:45
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…e-126012.2KalhG.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Might as well hop on the approval train :)

Copy link
Contributor

@rruuaanngrruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

brianschubert reacted with heart emoji
@sobolevnsobolevn merged commitdc76a4a intopython:mainOct 27, 2024
40 checks passed
picnixz added a commit to picnixz/cpython that referenced this pull requestDec 8, 2024
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

@picnixzpicnixzpicnixz approved these changes

@furkanonderfurkanonderfurkanonder approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

+1 more reviewer

@rruuaanngrruuaanngrruuaanng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brianschubert@sobolevn@picnixz@furkanonder@ZeroIntensity@rruuaanng
[8]ページ先頭
©2009-2025 Movatter.jp