Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-123930: Correct test of attribute failure to account for iOS#125959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
!buildbot iOS |
bedevere-bot commentedOct 25, 2024
🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit41ed908 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for the quick fix!
!buildbot iOS |
bedevere-bot commentedOct 25, 2024
🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit8111d82 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
75401fe intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…pythonGH-125959)Update a test of importing attributes from binary modules to account for iOS conditions.(cherry picked from commit75401fe)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
GH-125960 is a backport of this pull request to the3.13 branch. |
…for iOS (pythonGH-125959) (python#125960)pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)Update a test of importing attributes from binary modules to account for iOS conditions.(cherry picked from commit75401fe)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
…for iOS (pythonGH-125959) (python#125960)pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959)Update a test of importing attributes from binary modules to account for iOS conditions.(cherry picked from commit75401fe)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
…python#125959)Update a test of importing attributes from binary modules to account for iOS conditions.
#123929 improved the error message when a Python module shadows a binary module.
However, the test that was added didn't account for the behavior of the iOS import scheme. On iOS, the spec origin and the module's
__file__aren't equivalent, due to the iOS Framework loader. As a result, the test which was looking for the module's__file__in the exception that is raised failed on the iOS buildbots.On every other platform, The spec.origin and the module's
__file__are the same, so this PR updates the test to use the spec's origin.