Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Increase minimum Android API level to 24#125946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
!buildbot android |
bedevere-bot commentedOct 24, 2024
The change itself makes sense; but there's a merge conflict after#125941 landed; once that's resolved, I think this is good to land. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
371c537 intopython:mainUh oh!
There was an error while loading.Please reload this page.
freakboy3742 commentedOct 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Not sure why this passed a buildbot check on the PR, but then failed on the main... any ideas@mhsmith ? |
Actually it did not pass the buildbot check on the PR (click the red X against the "Remove skip" commit above). It looks like increasing the minimum API level has caused some additional libc APIs to become available at compile time, but they always return "permission denied" at runtime. This is a pretty common situation, so I'll make another PR to fix it. |
/me facepalms. I missed the original test failure, then assumed that the impact of a buildbot test failure would carry over into the subsequent merge-with-main build. |
Minimum Android API level has been increased to 24 (Android 7.0).
Backport miscellaneous Android testbed changes from#125946, but without theAndroid API version bump.
Uh oh!
There was an error while loading.Please reload this page.
This PR is stacked on top of#125941, which should be merged first. However, this PR should not be backported to 3.13, because that has already committed to a minimum API level of 21.
API level 24 wasreleased in 2016, and according tohttps://dl.google.com/android/studio/metadata/distributions.json, over 97% of active devices are on that version or newer.
Because of limitations in the
pidofandlogcatcommands, 24 is already the minimum API level supported by the test script – older versions had to be tested manually. So this will save some work for Python 3.14.