Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-125789: fixfut._callbacks to always return a copy of callbacks#125922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 2 commits intopython:mainfromkumaraditya303:callbacks
Oct 25, 2024

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commentedOct 24, 2024•
edited by bedevere-appbot
Loading

@kumaraditya303
Copy link
ContributorAuthor

== Tests result: SUCCESS ==1 test skipped:    test_asyncio.test_unix_events30 tests OK.Total duration: 6 min 8 secTotal tests: run=2,242 skipped=74Total test files: run=31/31 skipped=1Result: SUCCESS

Refleak tested

@kumaraditya303kumaraditya303 added topic-asyncio 3.12only security fixes 3.13bugs and security fixes needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes and removed 3.12only security fixes 3.13bugs and security fixes labelsOct 24, 2024
Copy link
Member

@picnixzpicnixz left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would add a test for that (e.g., one of the test that Nico wrote with the evil classes) to see that the interpreter does not crash anymore.

EDIT: My previous comment was wrong. We can still change the length by just adding new callbacks but we cannot change the type of the items.

@kumaraditya303
Copy link
ContributorAuthor

I would add a test for that (e.g., one of the test that Nico wrote with the evil classes) to see that the interpreter does not crash anymore.

I think it is more appropriate to add that to your PR which fixes the UAF issues.

@kumaraditya303kumaraditya303 merged commitcae853e intopython:mainOct 25, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks@kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@kumaraditya303, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker cae853e3b44cd5cb033b904e163c490dd28bc30a 3.13

@miss-islington-app
Copy link

Sorry,@kumaraditya303, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker cae853e3b44cd5cb033b904e163c490dd28bc30a 3.12

@bedevere-app
Copy link

GH-125976 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelOct 25, 2024
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull requestOct 25, 2024
…backs (python#125922)Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.(cherry picked from commitcae853e)
kumaraditya303 added a commit that referenced this pull requestOct 25, 2024
…lbacks (#125922) (#125976)GH-125789: fix `fut._callbacks` to always return a copy of callbacks (#125922)Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.(cherry picked from commitcae853e)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 25, 2024
…of callbacks (pythonGH-125922) (pythonGH-125976)pythonGH-125789: fix `fut._callbacks` to always return a copy of callbacks (pythonGH-125922)Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.(cherry picked from commitf54e1a2)Co-authored-by: Kumar Aditya <kumaraditya@python.org>(cherry picked from commitcae853e)
kumaraditya303 added a commit that referenced this pull requestOct 25, 2024
…lbacks (GH-125922) (#125977)GH-125789: fix `fut._callbacks` to always return a copy of callbacks (GH-125922)Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.Co-authored-by: Kumar Aditya <kumaraditya@python.org>(cherry picked from commitcae853e)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
…backs (python#125922)Fix `asyncio.Future._callbacks` to always return a copy of the internal list of callbacks to avoid mutation from user code affecting the internal state.
@hugovkhugovk removed the needs backport to 3.12only security fixes labelFeb 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

@kumaraditya303kumaraditya303

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303@picnixz@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp