Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-125843: indicate which C function caused acurses.error#125844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
27 commits Select commitHold shift + click to select a range
03fc9c5 improve `curses.error` object
picnixz3436f9b update error messages
picnixz73ce26c cosmetic changes!
picnixzcfe5468 blurb
picnixza8845ee update docs
picnixz1b1230d Merge remote-tracking branch 'upstream/main' into x-stale/feat/curses…
picnixz55a491a reduce diff
picnixz758dfe5 reduce diff even futher
picnixz3a3964b simplify logic
picnixz92e62cf simplify logic x2
picnixz4d8f47f reduce diff again!
picnixz5b8ff99 simplify logic x3
picnixz43d2e99 lint
picnixz12f0b30 reduce diff x4
picnixzeaaad71 reduce diff x5
picnixzb96b542 simplify even more!
picnixz39f102f nits(cosmetics)
picnixz6bc9c3e update messages
picnixz5addb78 remove un-necessary prototypes and rearrange code
picnixz34583e0 address review
picnixz236bea5 update error messages in `_curses_panel`
picnixz8188179 raise `curses.error` in `is_linetouched` instead of TypeError
picnixz9e6c83e Revert "update error messages in `_curses_panel`"
picnixz3989ddd fix typo
picnixzbf54774 correctly check `mouseinterval` return value
picnixz34a1c31 Merge remote-tracking branch 'upstream/main' into feat/curses/error-t…
picnixz6be3a15 reduce overall diff
picnixzFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
reduce diff again!
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit4d8f47ffb2f4517d410eb3a8cbe194b96c0f7d6a
There are no files selected for viewing
26 changes: 10 additions & 16 deletionsModules/_cursesmodule.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1076,7 +1076,6 @@ _curses_window_addstr_impl(PyCursesWindowObject *self, int group_left_1, | ||
| if (strtype == 0) { | ||
| return NULL; | ||
| } | ||
| if (use_attr) { | ||
| attr_old = getattrs(self->win); | ||
| (void)wattrset(self->win,attr); | ||
| @@ -1406,7 +1405,7 @@ _curses_window_box_impl(PyCursesWindowObject *self, int group_right_1, | ||
| return NULL; | ||
| } | ||
| } | ||
| (void)box(self->win,ch1,ch2); | ||
picnixz marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| Py_RETURN_NONE; | ||
| } | ||
| @@ -1504,15 +1503,14 @@ PyCursesWindow_ChgAt(PyObject *op, PyObject *args) | ||
| attr = attr & A_ATTRIBUTES; | ||
| if (use_xy) { | ||
| rtn = mvwchgat(self->win,y,x,num,attr,color,NULL); | ||
| curses_funcname = "mvwchgat"; | ||
| (void)touchline(self->win,y,1); | ||
picnixz marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| } else { | ||
| getyx(self->win,y,x); | ||
| rtn = wchgat(self->win,num,attr,color,NULL); | ||
| curses_funcname = "wchgat"; | ||
| (void)touchline(self->win,y,1); | ||
picnixz marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| } | ||
| return PyCursesCheckERR_ForWin_From(self, rtn, "chgat", curses_funcname); | ||
| } | ||
| @@ -1788,7 +1786,7 @@ _curses_window_get_wch_impl(PyCursesWindowObject *self, int group_right_1, | ||
| Py_BEGIN_ALLOW_THREADS | ||
| if (!group_right_1) { | ||
| ct = wget_wch(self->win ,&rtn); | ||
| } | ||
| else { | ||
| ct = mvwget_wch(self->win, y, x, &rtn); | ||
| @@ -3761,17 +3759,13 @@ _curses_setupterm_impl(PyObject *module, const char *term, int fd) | ||
| } | ||
| if (!curses_setupterm_called && setupterm((char *)term, fd, &err) == ERR) { | ||
| const char *s = "setupterm: unknown error"; | ||
picnixz marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| if (err == 0) { | ||
| s = "setupterm: could not find terminal"; | ||
| } else if (err == -1) { | ||
| s = "setupterm: could not find terminfo database"; | ||
| } | ||
| cursesmodule_state *state = get_cursesmodule_state(module); | ||
| PyErr_SetString(state->error, s); | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.