Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-125843: indicate which C function caused acurses.error#125844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 27 commits intopython:mainfrompicnixz:curses/improve-error-type-125843
May 19, 2025

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedOct 22, 2024
edited by github-actionsbot
Loading

@picnixzpicnixz marked this pull request as draftApril 25, 2025 11:02
@picnixzpicnixz changed the titlegh-125843: store the name of the curses C function or macro incurses.errorgh-125843: include which C function caused acurses.errorApr 25, 2025
@picnixzpicnixz changed the titlegh-125843: include which C function caused acurses.errorgh-125843: indicate which C function caused acurses.errorApr 25, 2025
@picnixzpicnixz marked this pull request as ready for reviewApril 25, 2025 19:35
Copy link
MemberAuthor

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, there are somefuncname that should be corrected but I need to see how they should really be corrected.

@picnixzpicnixz marked this pull request as draftApril 25, 2025 19:50
Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! This should add some clarity.

- use `curses_set_error_*` prefix for error helpers- remove some macros with predefined messages- cleanly report both NULL and ERR cases
@picnixz
Copy link
MemberAuthor

picnixz commentedMay 7, 2025
edited
Loading

I've decided to keep the explicit calls to reduce the number of helper functions. When the python function name is the same, the caller needs to pass NULL. It also avoids the_from suffixes. I also updated the_curses_panel module that I totally forgot.

Note: I can actually delay the curses_panel changes for a follow-up PR btw.

@picnixz
Copy link
MemberAuthor

I'll make a separate PR for_curses.panel as I want to merge the curses part now.

@picnixzpicnixz added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 19, 2025
@bedevere-bot

This comment was marked as resolved.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 19, 2025
@picnixz

This comment was marked as resolved.

@picnixzpicnixz added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 19, 2025
@bedevere-bot

This comment was marked as resolved.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 19, 2025
@picnixzpicnixz added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 19, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@picnixz for commit34a1c31 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F125844%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 19, 2025
Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, let's do it!
Thank you!

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@picnixzpicnixz merged commitee36db5 intopython:mainMay 19, 2025
39 checks passed
@picnixzpicnixz deleted the curses/improve-error-type-125843 branchMay 19, 2025 13:53
@picnixz
Copy link
MemberAuthor

Ok, so actually I broke another build bot. However, it's good that it's broken because this means that either my function call is wrong or something else was wrong.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou approved these changes

@Yhg1sYhg1sAwaiting requested review from Yhg1s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@picnixz@bedevere-bot@encukou

[8]ページ先頭

©2009-2025 Movatter.jp