Oct 22, 2024 · Oct 22, 2024 · Oct 22, 2024 · Oct 23, 2024 · Oct 23, 2024 · Oct 23, 2024
diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c
            PyErr_SetString(PyExc_RuntimeError, "corrupted future state");
            return NULL;
        }
        Py_INCREF(cb_tup);
        PyObject *cb = PyTuple_GET_ITEM(cb_tup, 0);
        int cmp = PyObject_RichCompareBool(cb, fn, Py_EQ);
        Py_DECREF(cb_tup);
        if (cmp == -1) {
            return NULL;
        }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1071,8 +1071,10 @@ _asyncio_Future_remove_done_callback_impl(FutureObj self, PyTypeObject cls,
		PyErr_SetString(PyExc_RuntimeError, "corrupted future state");
picnixz marked this conversation as resolved. OutdatedShow resolvedHide resolved
		return NULL;
		}
		Py_INCREF(cb_tup);
		PyObject *cb = PyTuple_GET_ITEM(cb_tup, 0);
Copy link Contributor Nico-PosadaOct 24, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. A little nitpicky, but the incref should be on`cb` not`cb_tup`. We don't necessarily care if the tuple gets deleted in PyObject_RichCompareBool, we care if`cb` gets deleted. This technically works because I don't think there's a way to delete`cb` at this point if the tuple can't be deleted, but it's still worth noting.
		int cmp = PyObject_RichCompareBool(cb, fn, Py_EQ);
		Py_DECREF(cb_tup);
		if (cmp == -1) {
		return NULL;
		}
Expand Down