Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-125746: Delay deprecatedzipimport.zipimporter.load_module removal time to 3.15#125748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brettcannon merged 8 commits intopython:mainfromWulian233:zipimport
Feb 11, 2025

Conversation

Wulian233
Copy link
Contributor

@Wulian233Wulian233 commentedOct 20, 2024
edited
Loading

#125746 (comment)

I would like to hold off on this change for one more version. Aquick GitHub search shows that 1.8k projects are still relying onload_module (and my regular expression isn't perfect, so I'm certain that we're missing some).

The new zipimport methods (I'm using "new" loosely here, I'm talking about the 3.10 methods) were onlyadded to typeshed in late June, so I would assume that many wereintentionally usingload_module overexec_module, because their IDE was telling them that it doesn't exist (to confirm that, adjusting myGitHub search shows that only 250 projects are usingexec_module). Similarly,load_module isn't marked as@deprecated on typeshed, so when we did add it, it's unlikely that people realized they needed to migrate.


📚 Documentation preview 📚:https://cpython-previews--125748.org.readthedocs.build/

@rruuaanng
Copy link
Contributor

I also encountered this problem, but I don't know why it happened. I opened an issue.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would like to postpone this until 3.15. Please update the PR to move theload_module deprecation topending-removal-in-3.15

@Wulian233Wulian233 changed the titlegh-125746: Remove deprecatedzipimport.zipimporter.load_modulegh-125746: Delay deprecatedzipimport.zipimporter.load_module removal time to 3.15Oct 20, 2024
@Wulian233
Copy link
ContributorAuthor

You're right, when I did this pr, my vscode (the latest Python extension) didn't prompt exec_module either. I will edit the pending-removal-in-3.15.rst and Lib/zipimport.py to remove the entries for pending-removal-in-future.rst

@Wulian233Wulian233 reopened thisOct 21, 2024
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! LGTM.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-app
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

Co-authored-by: Brett Cannon <brett@python.org>
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you check if there is adeprecated-removed directive to update in the corresponding docs entry?

@Wulian233
Copy link
ContributorAuthor

Wulian233 commentedNov 17, 2024
edited
Loading

@brettcannon Friendly ping:) maybe we can merge this? It should be fine now, thank you!

@rruuaanng
Copy link
Contributor

@Wulian233 Be patient, everyone has their own job :)

@ZeroIntensity
Copy link
Member

ZeroIntensity commentedNov 17, 2024
edited
Loading

Eh, IMO it's fine to remind someone to merge if the PR hasn't had any additional reviewers.

@Wulian233
Copy link
ContributorAuthor

Wulian233 commentedFeb 11, 2025
edited
Loading

A few months later: A similar PR for the delayed removal ofload_module inimportlib#129855 was just merged and backported. Is this PR still needed?

cc@brettcannon

@tomasr8
Copy link
Member

Is this PR still needed?

It is, this one updateszipimport, while the other one was forimportlib.

@brettcannonbrettcannonenabled auto-merge (squash)February 11, 2025 23:46
@brettcannonbrettcannon merged commit06ac157 intopython:mainFeb 11, 2025
39 checks passed
@brettcannon
Copy link
Member

Sorry for the delay! Got swamped and this fell off my radar thinking I was waiting on something for the PR.

@Wulian233Wulian233 deleted the zipimport branchFebruary 12, 2025 01:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

@brettcannonbrettcannonbrettcannon approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@Wulian233@rruuaanng@ZeroIntensity@tomasr8@brettcannon@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp