Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-125746: Delay deprecatedzipimport.zipimporter.load_module
removal time to 3.15#125748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I also encountered this problem, but I don't know why it happened. I opened an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would like to postpone this until 3.15. Please update the PR to move theload_module
deprecation topending-removal-in-3.15
zipimport.zipimporter.load_module
zipimport.zipimporter.load_module
removal time to 3.15You're right, when I did this pr, my vscode (the latest Python extension) didn't prompt exec_module either. I will edit the pending-removal-in-3.15.rst and Lib/zipimport.py to remove the entries for pending-removal-in-future.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you! LGTM.
Uh oh!
There was an error while loading.Please reload this page.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Brett Cannon <brett@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you check if there is adeprecated-removed
directive to update in the corresponding docs entry?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Library/2024-10-20-13-01-05.gh-issue-125746.wDLTay.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Wulian233 commentedNov 17, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@brettcannon Friendly ping:) maybe we can merge this? It should be fine now, thank you! |
@Wulian233 Be patient, everyone has their own job :) |
ZeroIntensity commentedNov 17, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Eh, IMO it's fine to remind someone to merge if the PR hasn't had any additional reviewers. |
Wulian233 commentedFeb 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
A few months later: A similar PR for the delayed removal of |
It is, this one updates |
06ac157
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Sorry for the delay! Got swamped and this fell off my radar thinking I was waiting on something for the PR. |
Uh oh!
There was an error while loading.Please reload this page.
#125746 (comment)
zipimport.zipimporter.load_module
removal time to 3.15 #125746📚 Documentation preview 📚:https://cpython-previews--125748.org.readthedocs.build/