Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119786: move interpreter doc from devguide to InternalDocs#125715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 6 commits intopython:mainfromiritkatriel:interpreter-doc
Oct 21, 2024

Conversation

Copy link
Contributor

@willingcwillingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@iritkatriel. I love that the internals docs are next to the code 😄

Comment on lines 22 to 23
Recall that the[Python Compiler](https://github.com/python/cpython/blob/main/InternalDocs/compiler.md)
produces a[`CodeObject`](https://github.com/python/cpython/blob/main/InternalDocs/code_object.md),
Copy link
Member

@AlexWaygoodAlexWaygoodOct 19, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think you might be able to get away with just this (also applies to a bunch of other links in this PR):

Suggested change
Recall that the[Python Compiler](https://github.com/python/cpython/blob/main/InternalDocs/compiler.md)
produces a[`CodeObject`](https://github.com/python/cpython/blob/main/InternalDocs/code_object.md),
Recall that the[Python Compiler](compiler.md) produces a[`CodeObject`](code_object.md),

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess I could also use relative links to the code (like../Python/bytecodes.c).

Copy link
Member

@AlexWaygoodAlexWaygoodOct 21, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Try it and see how it renders? You can get a good preview of how GitHub will render it by pushing to this PR branch, then clicking this "View file" button here from the "files changed" tab:

image

willingc reacted with laugh emoji
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! A couple of minor things I spotted:

willingc reacted with heart emoji
iritkatrieland others added2 commitsOctober 21, 2024 18:09
Co-authored-by: Jacob Coffee <jacob@z7x.org>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@willingc
Copy link
Contributor

🚢

@iritkatrieliritkatriel merged commit695814c intopython:mainOct 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@willingcwillingcwillingc approved these changes

@JacobCoffeeJacobCoffeeJacobCoffee approved these changes

@markshannonmarkshannonAwaiting requested review from markshannon

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel@willingc@JacobCoffee@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp