Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CI: Bump Python to 3.13 and mypy to 1.12 in mypy workflow#125592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Eclips4 merged 3 commits intopython:mainfromEclips4:bump-python-ci
Oct 16, 2024

Conversation

@Eclips4
Copy link
Member

I think that we're ready to bump python to 3.12 in mypy workflow, from what I can see atpython/mypy#15277, mypy almost supports 3.12 except forpython/mypy#15313.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A big +1 from me :)

@Eclips4
Copy link
MemberAuthor

FYI: There is a PR which failed due to Python 3.11 in the mypy workflow:#125589

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note that "supporting" a version in the mypy issue tracker is often a bit of a misnomer. Mypy has long supported running on Python 3.12 fine; it just may not necessarily have good support for type checking all new features in Python 3.12.

AlexWaygood and Eclips4 reacted with thumbs up emoji
@JelleZijlstra
Copy link
Member

We could even run it on 3.13 if we update to the latest mypy release (1.12).

AlexWaygood reacted with thumbs up emoji

@AlexWaygood
Copy link
Member

AlexWaygood commentedOct 16, 2024•
edited
Loading

(Mypy will still reject new-in-Python 3.12 features in some of the various directories it checks, even with this change, without changes such as the one Pablo is proposing to make to themypy.ini file in#125589. And that's deliberate: we want to ensure that some of our build tools can be run on older versions of Python.)

Eclips4 reacted with thumbs up emoji

@Eclips4Eclips4 changed the titleCI: Bump Python to 3.12 in mypy workflowCI: Bump Python to 3.13 and mypy to 1.12 in mypy workflowOct 16, 2024
@AlexWaygood
Copy link
Member

You get to remove atype: ignore comment from Argument Clinic that we don't need anymore, now 😃

Eclips4 reacted with thumbs up emojierlend-aasland reacted with rocket emoji

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@Eclips4Eclips4enabled auto-merge (squash)October 16, 2024 14:14
@Eclips4Eclips4 merged commitd83fcf8 intopython:mainOct 16, 2024
40 checks passed
@Eclips4Eclips4 deleted the bump-python-ci branchOctober 16, 2024 14:27
@Eclips4
Copy link
MemberAuthor

Do you think this should be backported to 3.13?

@AlexWaygood
Copy link
Member

If it backports cleanly, it's nice to have a consistent "CI experience" between the actively maintained branches. But I also wouldn't spend too much time on it if it doesn't backport cleanly :-)

JelleZijlstra, Eclips4, and erlend-aasland reacted with thumbs up emoji

@Eclips4Eclips4 added the needs backport to 3.13bugs and security fixes labelOct 16, 2024
@miss-islington-app
Copy link

Thanks@Eclips4 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@Eclips4, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d83fcf8371f2f33c7797bc8f5423a8bca8c46e5c 3.13

@bedevere-app
Copy link

GH-125596 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelOct 16, 2024
Eclips4 added a commit to Eclips4/cpython that referenced this pull requestOct 16, 2024
…honGH-125592)* Bump mypy to 1.12 & Python to 3.13* Remove unnecessary `type: ignore`(cherry picked from commitd83fcf8)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@Eclips4
Copy link
MemberAuthor

If it backports cleanly, it's nice to have a consistent "CI experience" between the actively maintained branches. But I also wouldn't spend too much time on it if it doesn't backport cleanly :-)

Talking about the 3.12 branch, I'm not sure if this should be done there. Running mypy on the 3.13 version may give false positives for the 3.12 version, so... what do you think?

@AlexWaygood
Copy link
Member

Talking about the 3.12 branch, I'm not sure if this should be done there. Running mypy on the 3.13 version may give false positives for the 3.12 version, so... what do you think?

As long as thepython_version field is set to 3.12 or less in all the mypy.ini files on the 3.12 branch, it shouldn'ttheoretically be an issue to backport it to the 3.12 branch

Eclips4 reacted with thumbs up emoji

@Eclips4Eclips4 added the needs backport to 3.12only security fixes labelOct 16, 2024
@miss-islington-app
Copy link

Thanks@Eclips4 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@Eclips4, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d83fcf8371f2f33c7797bc8f5423a8bca8c46e5c 3.12

Eclips4 added a commit to Eclips4/cpython that referenced this pull requestOct 16, 2024
…honGH-125592)* Bump mypy to 1.12 & Python to 3.13* Remove unnecessary `type: ignore`(cherry picked from commitd83fcf8)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Eclips4 added a commit that referenced this pull requestOct 16, 2024
#125596)[3.13] CI: Bump Python to 3.13 and mypy to 1.12 in mypy workflow (GH-125592)(cherry picked from commitd83fcf8)
@Eclips4Eclips4 removed the needs backport to 3.12only security fixes labelOct 16, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
)* Bump mypy to 1.12 & Python to 3.13* Remove unnecessary `type: ignore`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@sobolevnsobolevnsobolevn approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninja

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

@Eclips4Eclips4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eclips4@JelleZijlstra@AlexWaygood@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp