With that PR,test_capi is no longer leaking:

admin@Admins-MacBook-Air~/p/cpython (revert-of-revert)> ./python.exe-mtest-R3:3test_capiUsingrandomseed:9920954540:00:00loadavg:26.10Run1testsequentiallyinasingleprocess0:00:00loadavg:26.10 [1/1]test_capibeginning6repetitions.Showingnumberofleaks (.for0orless,Xfor10ormore)123:456XX. ...test_capipassedin43.3sec==Testsresult:SUCCESS==1testOK.Totalduration:43.4secTotaltests:run=985skipped=67Totaltestfiles:run=1/1Result:SUCCESS

gh-125512: Revert#125513 and fix reference cycle#125532

It's not a revert, but a revert of a revert :-D The PR title should begh-124872: Replace enter/exit events with "switched.

I suggest to wait after Python 3.14.0 alpha1 release to retry this change.

I suggest to wait after Python 3.14.0 alpha1 release to retry this change.

Why? We can debug and fix the ref leak.

@rhansen Please build CPython with./configure --with-pydebug and run the tests with-R3:3. That will take much longer so I suggest just running asyncio & contextvars & decimal tests with this flag.

me:

I suggest to wait after Python 3.14.0 alpha1 release to retry this change.

@1st1:

Why?

It's just that there aremany broken buildbots, I think that this change can wait for 3.14.0a2.

FYI, I ran the test suite in hunt refleaks mode locally and it succeeded:

==Testsresult:SUCCESS==25testsskipped:test.test_asyncio.test_windows_eventstest.test_asyncio.test_windows_utilstest.test_gdb.test_backtracetest.test_gdb.test_cfunctiontest.test_gdb.test_cfunction_fulltest.test_gdb.test_misctest.test_gdb.test_pretty_printtest.test_multiprocessing_fork.test_managertest.test_multiprocessing_fork.test_misctest.test_multiprocessing_fork.test_processestest.test_multiprocessing_fork.test_threadstest_androidtest_dbm_gnutest_devpolltest_epolltest_free_threadingtest_launchertest_msvcrttest_perf_profilertest_perfmapstest_startfiletest_winapitest_winconsoleiotest_winregtest_wmi11testsskipped (resourcedenied):test_cursestest_peg_generatortest_pyrepltest_smtpnettest_socketservertest_tkintertest_ttktest_urllib2nettest_urllibnettest_winsoundtest_zipfile64442testsOK.Totalduration:20min5secTotaltests:run=44,347skipped=2,182Totaltestfiles:run=467/478skipped=25resource_denied=11Result:SUCCESS

@Eclips4 thanks for fixing the leak!

@vstinner

It's just that there aremany broken buildbots, I think that this change can wait for 3.14.0a2.

I sympathize, really sorry about breaking them and causing pain :/ Can we try landing this PR since it appears it should solve the issue? I'm afraid if we wait on this for a month to get it merged it will go stale and we just forget. I'd try again and if it fails we wait? If however you really don't want to do it, then fine.

Since we're about to release a1 tonight, I'd wait with landing this until right after a1. We won't forget about it.

Actually,@hugovk should make the call.

Yeah, same call, thanks :)

@ambv@vstinner

Since we're about to release a1 tonight, I'd wait with landing this until right after a1. We won't forget about it.

Oh I was reading the schedule wrong. I didn't realize Victor wants to delay it just one day, essentially, I thought we were talking one month to merge this. Absolutely can wait a few days.

Thanks, a1 is now out, merge whenever you're ready.

I applied@rhansen's change, before that, the test did nothing :-)

Also, would you mind fixing up the commit message, authorship info, etc. on the first commit:

That sounds like a good idea :-) Or at least, make sure that@rhansen is mentioned as a co-author of the change.

Apologies for the breakage, and thank you for debugging!

Is a blurb required now that there's an API change between v3.14.0a1 and v3.14.0a2?

Also, would you mind fixing up the commit message, authorship info, etc. on the first commit:

git -c sequence.editor='sed -i -e "1s/^pick/edit/"' rebase -i main&&git commit --amend -C 843d28f59d2&&git rebase --continue

Sorry about that! I definitely will do it.

@rhansen it seems I have done it. If you agree, I will merge it.

(I'm actually do not understand why forf0b3aa862b629690496d0336904a9bb1ada6dd47 github is treating me as co-author...)

(I'm actually do not understand why forf0b3aa8 github is treating me as co-author...)

GitHub is correct when saying:

rhansenauthored and Eclips4committed

Should this get tested with the refleak buildbots?

Should this get tested with the refleak buildbots?

I don't think so. I tested test_capi manually, and@Eclips4ran the whole test suite with-R 3:3.