Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-125498: Update JIT builds to use LLVM 19 and usepreserve_none#125499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 48 commits intopython:mainfromsavannahostrowski:remove-ghccc
Oct 30, 2024

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commentedOct 15, 2024
edited
Loading

@savannahostrowski
Copy link
MemberAuthor

So it looks like the Python version installed withbrew is failing transitively...doing a bit of spelunking here.

@savannahostrowski
Copy link
MemberAuthor

savannahostrowski commentedOct 22, 2024
edited
Loading

Okay, after a bit of digging here, my cursory diagnosis around the failing x86 macOS runs is essentially this (and I am by no means a Homebrew or Ruby expert):
- The default Python version of Homebrew was recently updated to 3.13 (seeHomebrew/homebrew-core#182840). As part of this PR, the formula for Python 3.13 seem to vastly differ from 3.12...and 3.12 was also updated.
It seems like Homebrew is no longer handling overwriting files in the way it once did. More specifically, the combo of thesetup-python step and thenbrew installing Python (via LLVM) is not cooperating. I did some testing here, and it looks like this issue only happens with 3.12 onward (preliminary run ofhttps://github.com/savannahostrowski/test_repo_python_install/actions/runs/11453722971 but waiting on thefail-fast: false run for the full output).

Update as of 10/22:
I got a reply from a Homebrew maintainer:Homebrew/homebrew-core#195288. It looks like this is a known GHA issue that has existed since at least May and started popping up recently as a result of some updates that GitHub made to runner images. The workaround is to remove the symlink to the pre-installed Python so that Homebrew Python is used instead. They may also start investigating overwriting the symlinks when in GHA context on their end because this seems to be a prevalent issue.

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, just a few opportunities to tidy things up:

…e-125498.cFjPIn.rstCo-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@savannahostrowski
Copy link
MemberAuthor

Oooo, thanks for the review@brandtbucher. Great catches for cleaning things up a bit. Much simpler.

@savannahostrowskisavannahostrowski changed the titlegh-125498: Replace ghccc withpreserve_none in JIT buildsgh-125498: Update JIT builds to use LLVM 19 and usepreserve_noneOct 30, 2024
Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome!@mdboom, I'm landing this, so we should probably also update the benchmark runners that need it. Let me know if you want help.

savannahostrowski and mdboom reacted with rocket emoji
@brandtbucherbrandtbucher merged commitc29bbe2 intopython:mainOct 30, 2024
71 checks passed
@mdboom
Copy link
Contributor

Awesome!@mdboom, I'm landing this, so we should probably also update the benchmark runners that need it. Let me know if you want help.

Yep -- I'll do that now.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

@markshannonmarkshannonAwaiting requested review from markshannon

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savannahostrowski@mdboom@brandtbucher

[8]ページ先頭

©2009-2025 Movatter.jp