Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-125498: Update JIT builds to use LLVM 19 and usepreserve_none#125499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
So it looks like the Python version installed with |
savannahostrowski commentedOct 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Update as of 10/22: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, just a few opportunities to tidy things up:
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Core_and_Builtins/2024-10-22-04-18-53.gh-issue-125498.cFjPIn.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…e-125498.cFjPIn.rstCo-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Oooo, thanks for the review@brandtbucher. Great catches for cleaning things up a bit. Much simpler. |
preserve_none in JIT buildspreserve_noneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome!@mdboom, I'm landing this, so we should probably also update the benchmark runners that need it. Let me know if you want help.
c29bbe2 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Yep -- I'll do that now. |
…e_none (pythonGH-125499)"This reverts commitc29bbe2.
Uh oh!
There was an error while loading.Please reload this page.
preserve_nonein JIT builds #125498