Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
gh-125420: implementSequence.count API onmemoryview objects#125443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-125420: implementSequence.count API onmemoryview objects#125443
Uh oh!
There was an error while loading.Please reload this page.
Conversation
count tomemoryview objectsSequence.count API onmemoryview objectsUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| Py_DECREF(iter); | ||
| returnNULL; | ||
| } | ||
| intcontained=PyObject_RichCompareBool(item,value,Py_EQ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
list.count has a special case forif (item == value) count++. I suspect that helps significantly here too, because the value item will usually be an interned integer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually,PyObject_RichCompareBool has that fast path inside as well. I had the fast path before but then I wondered whether it was really needed or not (and I was a bit too lazy for benchmarkings). But I forgot about the interned integer case so it's probably faster.
| Py_ssize_tcount=0; | ||
| PyObject*item=NULL; | ||
| while (PyIter_NextItem(iter,&item)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could probably make this significantly more efficient by looking at the memory directly without materializing an iterator and all the elements.str.count is a similar example. However, that is going to be a lot more complicated, so it seems fine to skip it; if somebody wants to optimize this method later they can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, that's what I suspected so I went for the simplest approach (at least to have the code around).
4331832 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--125443.org.readthedocs.build/