Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-125355: Rewrite parse_intermixed_args() in argparse#125356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-125355: Rewrite parse_intermixed_args() in argparse#125356
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* The parser is no longer temporary modified and can be used concurrently.* Default values are no long handled twice.* Report about missed arguments now contains names of all required optional and positional arguments.* Unknown options can be intermixed with positionals in parse_known_intermixed_args().
| parser.parse_intermixed_args([]) | ||
| msg=str(cm.exception) | ||
| self.assertNotRegex(msg,'req_pos') | ||
| self.assertRegex(msg,'req_pos') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was a bug.
| self.assertEqual(NS(bar='y',cmd='cmd',foo='x',rest=[1]),args) | ||
| self.assertEqual(['--error','2','3'],extras) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think that was a bug. The result was different depending on the position of unknown option.
| parser=ErrorRaisingArgumentParser(prog='PROG') | ||
| parser.add_argument('--foo',nargs="*") | ||
| parser.add_argument('foo') | ||
| withself.assertWarns(UserWarning): | ||
| parser.parse_intermixed_args(['hello','--foo']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| if (hasattr(namespace,action.dest) | ||
| andgetattr(namespace,action.dest)==[]): | ||
| fromwarningsimportwarn | ||
| warn('Do not expect %s in %s'% (action.dest,namespace)) | ||
| delattr(namespace,action.dest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I do not understand this code. There were no tests, and the purpose is not clear to me.@hpaulj,@bitdancer, could you shed some light on this?
759a54d intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…H-125356)* The parser no longer changes temporarily during parsing.* Default values are not processed twice.* Required mutually exclusive groups containing positional arguments are now supported.* The missing arguments report now includes the names of all required optional and positional arguments.* Unknown options can be intermixed with positional arguments in parse_known_intermixed_args().(cherry picked from commit759a54d)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sorry,@serhiy-storchaka, I could not cleanly backport this to |
GH-125834 is a backport of this pull request to the3.13 branch. |
) (GH-125834)* The parser no longer changes temporarily during parsing.* Default values are not processed twice.* Required mutually exclusive groups containing positional arguments are now supported.* The missing arguments report now includes the names of all required optional and positional arguments.* Unknown options can be intermixed with positional arguments in parse_known_intermixed_args().(cherry picked from commit759a54d)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…ythonGH-125356)* The parser no longer changes temporarily during parsing.* Default values are not processed twice.* Required mutually exclusive groups containing positional arguments are now supported.* The missing arguments report now includes the names of all required optional and positional arguments.* Unknown options can be intermixed with positional arguments in parse_known_intermixed_args().(cherry picked from commit759a54d)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-125839 is a backport of this pull request to the3.12 branch. |
) (GH-125839)* The parser no longer changes temporarily during parsing.* Default values are not processed twice.* Required mutually exclusive groups containing positional arguments are now supported.* The missing arguments report now includes the names of all required optional and positional arguments.* Unknown options can be intermixed with positional arguments in parse_known_intermixed_args().(cherry picked from commit759a54d)
…H-125356)* The parser no longer changes temporarily during parsing.* Default values are not processed twice.* Required mutually exclusive groups containing positional arguments are now supported.* The missing arguments report now includes the names of all required optional and positional arguments.* Unknown options can be intermixed with positional arguments in parse_known_intermixed_args().
Uh oh!
There was an error while loading.Please reload this page.