Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
GH-125174: Make immortal objects more robust, following design from PEP 683#125251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
markshannon commentedOct 10, 2024
This is not a complete fix for#125174, just enough to unblock other work |
bedevere-bot commentedOct 10, 2024
🤖 New build scheduled with the buildbot fleet by@markshannon for commit94f8fd0 🤖 If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again. |
markshannon commentedOct 10, 2024
The two "failing" refleak buildbots seem to be hanging in |
markshannon commentedOct 10, 2024
Performance impact: Overall a small slowdown, with a large 7-10% slowdown on nbody. I'll re-run the linux benchmarks with the fix as a sanity check. |
Uh oh!
There was an error while loading.Please reload this page.
markshannon commentedOct 10, 2024
Windows shows an over 2% improvement. With the regression fixed, this I would expect this to be more than 3%. This reason for this is that the MSVC does not convert |
markshannon commentedOct 10, 2024
x86-64 linux performance numbers are a bit noisy, but show no significant change. |
c901437 intopython:mainUh oh!
There was an error while loading.Please reload this page.
python/cpython#125251 renamed_PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT
* MNT: account for CPython 314 changespython/cpython#125251 renamed_PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT* Define new macro to reduce duplication---------Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.