Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.12] gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865)#125205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedOct 9, 2024
edited by bedevere-appbot
Loading

Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.

This is an un-revert ofgh-124646 that then addresses the Py_TRACE_REFS
failures identified bygh-124785.
(cherry picked from commitf2cb399)

Co-authored-by: Eric Snowericsnowcurrently@gmail.com

…ythongh-124865)Fix a crash caused by immortal interned strings being shared betweensub-interpreters that use basic single-phase init. In that case, the stringcan be used by an interpreter that outlives the interpreter that created andinterned it. For interpreters that share obmalloc state, also share theinterned dict with the main interpreter.This is an un-revert ofpythongh-124646 that then addresses the Py_TRACE_REFSfailures identified bypythongh-124785.(cherry picked from commitf2cb399)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ericsnowcurrently
Copy link
Member

@nascheme I thought the backport wouldn't apply cleanly, but here we are. Do you recall what was different about the 3.12 fix?

@vstinner
Copy link
Member

Please don't merge until the TraceRefs regression is fixed:#124865 (comment)

ericsnowcurrently reacted with thumbs up emoji

@nascheme
Copy link
Member

I think this can be merged now withGH-125709 applied on top or squashed into it.

…ers (pythongh-125709)They used to be shared, before 3.12.  Returning to sharing them resolves a failure on Py_TRACE_REFS builds.
@encukou
Copy link
Member

@ericsnowcurrently, is this the way you'd do it in 3.12?

@encukouencukou added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelDec 2, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commite9591b2 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelDec 2, 2024
@encukou
Copy link
Member

The failed buildbots aren't applicable to 3.12, or fail for unrelated & pre-existing reasons.

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently, is this the way you'd do it in 3.12?

This should be good to go. It is backport ofgh-124865 +gh-125709. There shouldn't be anything particular to 3.12 that would need to be addressed differently.

@ericsnowcurrentlyericsnowcurrently merged commit49da170 intopython:3.12Dec 3, 2024
90 of 105 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@miss-islington@ericsnowcurrently@vstinner@nascheme@encukou@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp