Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.13] gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865)#125204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 2 commits intopython:3.13frommiss-islington:backport-f2cb399-3.13
Nov 12, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commentedOct 9, 2024•
edited by bedevere-appbot
Loading

Fix a crash caused by immortal interned strings being shared between
sub-interpreters that use basic single-phase init. In that case, the string
can be used by an interpreter that outlives the interpreter that created and
interned it. For interpreters that share obmalloc state, also share the
interned dict with the main interpreter.

This is an un-revert ofgh-124646 that then addresses the Py_TRACE_REFS
failures identified bygh-124785.
(cherry picked from commitf2cb399)

Co-authored-by: Eric Snowericsnowcurrently@gmail.com

…ythongh-124865)Fix a crash caused by immortal interned strings being shared betweensub-interpreters that use basic single-phase init. In that case, the stringcan be used by an interpreter that outlives the interpreter that created andinterned it. For interpreters that share obmalloc state, also share theinterned dict with the main interpreter.This is an un-revert ofpythongh-124646 that then addresses the Py_TRACE_REFSfailures identified bypythongh-124785.(cherry picked from commitf2cb399)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@vstinner
Copy link
Member

Please don't merge until the TraceRefs regression is fixed:#124865 (comment)

ericsnowcurrently reacted with thumbs up emoji

@nascheme
Copy link
Member

I think this can be merged now withGH-125709 applied on top or squashed into it.

…ers (pythongh-125709)They used to be shared, before 3.12.  Returning to sharing them resolves a failure on Py_TRACE_REFS builds.
@encukouencukou merged commit02cd3ce intopython:3.13Nov 12, 2024
39 checks passed
@encukouencukou added the needs backport to 3.12only security fixes labelNov 13, 2024
@miss-islington-app
Copy link

Thanks@miss-islington for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@miss-islington and@encukou, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 02cd3ce0f201df98939c65bcba8445bb0b70717b 3.12
encukou reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou left review comments

@Yhg1sYhg1sYhg1s approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

@encukouencukou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@miss-islington@vstinner@nascheme@encukou@Yhg1s@ericsnowcurrently
[8]ページ先頭
©2009-2025 Movatter.jp