Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-124502: Remove _PyUnicode_EQ() function#125114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 2 commits intopython:mainfromvstinner:remove_unicode_eq
Oct 9, 2024

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedOct 8, 2024•
edited by bedevere-appbot
Loading

  • Replace unicode_compare_eq() with unicode_eq().
  • Replace _PyUnicode_EQ() with _PyUnicode_Equal().
  • Remove unicode_compare_eq() and _PyUnicode_EQ().

* Replace unicode_compare_eq() with unicode_eq().* Replace _PyUnicode_EQ() with _PyUnicode_Equal().* Remove unicode_compare_eq() and _PyUnicode_EQ().
@vstinner
Copy link
MemberAuthor

Forsetobject.c, I decided to reuseunicode_eq() ofObjects/stringlib/eq.h instead of_PyUnicode_Equal(), because_PyUnicode_Equal() repeatsstr1 == str2 test which is already done bysetobject.c.

dictobject.c also usesunicode_eq() ofObjects/stringlib/eq.h for a similar reason (and for best performance, I suppose).

@vstinner
Copy link
MemberAuthor

cc@serhiy-storchaka

@vstinnervstinner merged commite0c87c6 intopython:mainOct 9, 2024
37 checks passed
@vstinnervstinner deleted the remove_unicode_eq branchOctober 9, 2024 08:15
@vstinner
Copy link
MemberAuthor

Merged, thanks for the review@serhiy-storchaka.

efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull requestOct 9, 2024
* Replace unicode_compare_eq() with unicode_eq().* Use unicode_eq() in setobject.c.* Replace _PyUnicode_EQ() with _PyUnicode_Equal().* Remove unicode_compare_eq() and _PyUnicode_EQ().
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp