Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119535: Support 𝜋thon in Python 3.14 venvs#125035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromforeignmeloman:main
Oct 15, 2024
Merged

gh-119535: Support 𝜋thon in Python 3.14 venvs#125035

hugovk merged 1 commit intopython:mainfromforeignmeloman:main
Oct 15, 2024

Conversation

foreignmeloman
Copy link
Contributor

@foreignmelomanforeignmeloman commentedOct 7, 2024•
edited by hugovk
Loading

ArtyomVancyan, thesamesam, Wulian233, armeni, mkdotam, gorkettsyan, smbarseghyan, RubenBejanyan, DavidIsrayelyan, nineteendo, and 31 more reacted with thumbs up emoji
@ghost
Copy link

ghost commentedOct 7, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@skirpichev
Copy link
Contributor

I would guess, it's already too late;) And sounds wrongly: "Pi", not "Py".

foreignmeloman reacted with confused emoji

@hugovk
Copy link
Member

It's not too late.

In English, the py ofpython andpi are pronounced the same:/paɪ/ in IPA.

AA-Turner, mherkhachatryan, Abdoulrasheed, and NotAsea reacted with thumbs up emojiforeignmeloman reacted with hooray emoji

@thatbirdguythatuknownot
Copy link
Contributor

Also doesn't reveal the easter egg to terminal autocomplete (as far as i know autocomplete goes)

foreignmeloman reacted with eyes emoji

@foreignmeloman
Copy link
ContributorAuthor

Also doesn't reveal the easter egg to terminal autocomplete (as far as i know autocomplete goes)

Was it intended to show during the tab completion?

@@ -306,7 +306,7 @@ def setup_python(self, context):

suffixes = ['python', 'python3', f'python3.{sys.version_info[1]}']
if sys.version_info[:2] == (3, 14):
suffixes.append('python𝜋')
suffixes.append('𝜋thon')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why can't we have both of them? 😄

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should decide on one option. An easter egg should be unique, otherwise it'll loose its punch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(I suggest creating the concept of an easter omlet)

hugovk, Eclips4, foreignmeloman, ZeroIntensity, fohrloop, nineteendo, samhaswon, hauntsaninja, mherkhachatryan, itamaro, and 25 more reacted with laugh emoji
Copy link
Contributor

@hauntsaninjahauntsaninja left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hugo asked me if I have an opinion on this. I don't have a strong opinion, but for whatever it's worth I chosepython𝜋 in the original PR because:

  • I think it's much easier to use, since your tab completion is narrowed to like four options. Especially so after the switch from U+03c0 to U+1d70b (I can type U+03c0 on my keyboard pretty easily but not U+1d70b)
  • Subjective, but to me some of the joke comes from the substitution of 3.14 in the "python3.14" file that venv creates. It's clearer that it's specific to this specific version of Python

hugovk, solevi, and TurnrDev reacted with thumbs up emoji
@hugovk
Copy link
Member

Okay, let's go for this one :)

Remember, everyone: shhh!

adamchainz, J3r0github, joveice, ewjoachim, mikavilpas, falcotinnunculus, tigerhawkvok, lu0, mitelg, samyilin, and 20 more reacted with laugh emoji

@hugovkhugovk changed the titlegh-119535:𝜋thon looks and sounds way coolergh-119535: Support 𝜋thon in Python 3.14 venvsOct 15, 2024
@hugovkhugovk merged commitfcef3fc intopython:mainOct 15, 2024
34 checks passed
hugovk added a commit to hugovk/cpython that referenced this pull requestMay 15, 2025
hauntsaninja pushed a commit that referenced this pull requestMay 15, 2025
* Revert "gh-119535: Support 𝜋thon in Python 3.14 venvs (#125035)"This reverts commitfcef3fc.* Revert "gh-119535: python𝜋 (#119536)"This reverts commit3fc673e.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

@hauntsaninjahauntsaninjahauntsaninja left review comments

@Eclips4Eclips4Eclips4 left review comments

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@foreignmeloman@skirpichev@hugovk@thatbirdguythatuknownot@picnixz@hauntsaninja@Eclips4
[8]ページ先頭
©2009-2025 Movatter.jp