Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-124969: Fix locale.nl_langinfo(locale.ALT_DIGITS)#124974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedOct 4, 2024•
edited by github-actionsbot
Loading

Now it returns a tuple of up to 100 strings (an empty tuple on most locales).Previously it returned the first item of that tuple or an empty string.
@serhiy-storchakaserhiy-storchakaforce-pushed thelocale-nl_langinfo-alt_digits branch from999217d toe062187CompareOctober 8, 2024 09:10
@serhiy-storchakaserhiy-storchaka marked this pull request as ready for reviewOctober 8, 2024 09:10
@serhiy-storchakaserhiy-storchaka added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelOct 8, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commit157c23e 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelOct 8, 2024
@serhiy-storchaka
Copy link
MemberAuthor

Thank you for your review@methane. I wonder what happened with ALT_DIGITS on macOS whether it only for Japanese (which have lesser need of this info forstrftime()/strptime()) or for all locales. In any case this is no our fault.

@serhiy-storchakaserhiy-storchaka merged commit21c04e1 intopython:mainOct 9, 2024
@serhiy-storchakaserhiy-storchaka deleted the locale-nl_langinfo-alt_digits branchOctober 9, 2024 08:42
@serhiy-storchakaserhiy-storchaka added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsOct 9, 2024
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@encukou
Copy link
Member

efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull requestOct 9, 2024
…124974)Now it returns a tuple of up to 100 strings (an empty tuple on most locales).Previously it returned the first item of that tuple or an empty string.
@serhiy-storchaka
Copy link
MemberAuthor

Thanks. Should be fixed by#125177.

@serhiy-storchakaserhiy-storchaka removed needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsOct 10, 2024
@serhiy-storchakaserhiy-storchaka added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsOct 10, 2024
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 21c04e1a972bd1b6285e0ea41fa107d635bbe43a 3.12

@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 21c04e1a972bd1b6285e0ea41fa107d635bbe43a 3.13

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestOct 10, 2024
…thonGH-124974)Now it returns a tuple of up to 100 strings (an empty tuple on most locales).Previously it returned the first item of that tuple or an empty string.(cherry picked from commit21c04e1)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-125232 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelOct 10, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestOct 10, 2024
…thonGH-124974)Now it returns a tuple of up to 100 strings (an empty tuple on most locales).Previously it returned the first item of that tuple or an empty string.(cherry picked from commit21c04e1)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchakaserhiy-storchaka removed the needs backport to 3.12only security fixes labelOct 10, 2024
@serhiy-storchakaserhiy-storchaka removed their assignmentOct 10, 2024
freakboy3742 pushed a commit that referenced this pull requestOct 10, 2024
… (#125232)Returns a tuple of up to 100 strings for ALT_DIGITS lookup (an empty tuple on most locales).Previously it returned the first item of that tuple or an empty string.(cherry picked from commit21c04e1)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 10, 2024
…thonGH-124974) (pythonGH-125232)(cherry picked from commit26a9318)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Returns a tuple of up to 100 strings for ALT_DIGITS lookup (an empty tuple on most locales).Previously it returned the first item of that tuple or an empty string.(cherry picked from commit21c04e1)
serhiy-storchaka added a commit that referenced this pull requestOct 11, 2024
…H-124974) (GH-125232) (GH-125284)(cherry picked from commit26a9318)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Returns a tuple of up to 100 strings for ALT_DIGITS lookup (an empty tuple on most locales).Previously it returned the first item of that tuple or an empty string.(cherry picked from commit21c04e1)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestOct 21, 2024
… a string againThis is a follow up ofpythonGH-124974. Only Glibc needed a fix.Now the returned value is a string consisting of semicolon-separatedsymbols on all Posix platforms.
serhiy-storchaka added a commit that referenced this pull requestOct 21, 2024
…ing again (GH-125774)This is a follow up ofGH-124974. Only Glibc needed a fix.Now the returned value is a string consisting of semicolon-separatedsymbols on all Posix platforms.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 21, 2024
… a string again (pythonGH-125774)This is a follow up ofpythonGH-124974. Only Glibc needed a fix.Now the returned value is a string consisting of semicolon-separatedsymbols on all Posix platforms.(cherry picked from commitdcc4fb2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 21, 2024
… a string again (pythonGH-125774)This is a follow up ofpythonGH-124974. Only Glibc needed a fix.Now the returned value is a string consisting of semicolon-separatedsymbols on all Posix platforms.(cherry picked from commitdcc4fb2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestOct 21, 2024
…g a string again (GH-125774) (GH-125805)This is a follow up ofGH-124974. Only Glibc needed a fix.Now the returned value is a string consisting of semicolon-separatedsymbols on all Posix platforms.(cherry picked from commitdcc4fb2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestOct 21, 2024
…g a string again (GH-125774) (GH-125804)This is a follow up ofGH-124974. Only Glibc needed a fix.Now the returned value is a string consisting of semicolon-separatedsymbols on all Posix platforms.(cherry picked from commitdcc4fb2)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
… a string again (pythonGH-125774)This is a follow up ofpythonGH-124974. Only Glibc needed a fix.Now the returned value is a string consisting of semicolon-separatedsymbols on all Posix platforms.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@methanemethanemethane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@bedevere-bot@encukou@methane
[8]ページ先頭
©2009-2025 Movatter.jp