NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.12] gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal (GH-121358) (GH-121851)#124938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

encukou merged 1 commit intopython:3.12fromencukou:3.12-static-immortal-skip-assert

Oct 4, 2024

Merged

[3.12] gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal (GH-121358) (GH-121851)#124938

encukou merged 1 commit intopython:3.12fromencukou:3.12-static-immortal-skip-assert

Oct 4, 2024

Conversation

Copy link

Member

encukou commentedOct 3, 2024•
edited by bedevere-appbot
Loading

Older stable ABI extensions are allowed to make immortal objects mortal. Instead, use_PyUnicode_STATE (interned andstatically_allocated).

(cherry picked from commit956270d)

Fixes:gh-124887

Issue:Interned strings are immortal, despite what the documentation says #113993

[3.12]pythongh-113993: For string interning, do not rely on (or asse…

3e07c20

…rt) _Py_IsImmortal (pythonGH-121358) (pythonGH-121851)pythongh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal (pythonGH-121358)Older stable ABI extensions are allowed to make immortal objects mortal.Instead, use `_PyUnicode_STATE` (`interned` and `statically_allocated`).(cherry picked from commit956270d)Co-authored-by: Petr Viktorin <encukou@gmail.com>