Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
gh-124653: relax (again) detection of queue API for logging handlers#124897
Conversation
picnixz commentedOct 2, 2024
Uh oh!
There was an error while loading.Please reload this page.
picnixz commentedOct 2, 2024
This entire issue makes me wonder whether |
YvesDup commentedOct 2, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
If it is necessary to use a Updated: perharps adding this case would be nice ? |
picnixz commentedOct 2, 2024
I didn't add it because I think it's a bit straightforward. If we add such method in the future to the base class, the test will detect that the class is no longer deemed invalid and if we do not, then the case is already covered by the minimal interface (I think this should be enough). |
bedevere-bot commentedOct 2, 2024
picnixz commentedOct 3, 2024
So we only have a single build bot failure which we already know the reason for. Ithink this issue will not haunt me again :D (just waiting for@vsajip's green light). |
Uh oh!
There was an error while loading.Please reload this page.
vsajip left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for this PR!
Uh oh!
There was an error while loading.Please reload this page.
picnixz commentedOct 7, 2024
@vsajip friendly ping in case you forgot to merge after approving the PR :') |
…dlers (pythonGH-124897)(cherry picked from commit7ffe94f)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…dlers (pythonGH-124897)(cherry picked from commit7ffe94f)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-125059 is a backport of this pull request to the3.13 branch. |
GH-125060 is a backport of this pull request to the3.12 branch. |
picnixz commentedOct 7, 2024
Huh... I think I forgot to update the JIT ignored files... I hope the test won't make the JIT fail. |
picnixz commentedOct 7, 2024
Seems the JIT is fine. |
Uh oh!
There was an error while loading.Please reload this page.
NOw we really have a minmal inteface, namely
put_nowaitandget. More than that is not needed for the default handlers and listeners.I think, we had a misunderstanding between what the docs told (namely a queue API) and what we expected at runtime.
SimpleQueueisnot the compatible with "queue.Queue" since it lacks some methods and neither ismultiprocessing.SimpleQueuewould never work since it does not even have theput_nowaitmethod (so even before my PRs, this would just break at runtime due to a missing interface).So itis correct to raise if the queue interface is
multiprocessing.SimpleQueue.📚 Documentation preview 📚:https://cpython-previews--124897.org.readthedocs.build/