Oct 9, 2024 · Oct 1, 2024 · Oct 1, 2024 · Oct 1, 2024 · Oct 1, 2024 · Oct 1, 2024
diff --git a/Objects/object.c b/Objects/object.c


 #ifdef Py_TRACE_REFS
 void
 _Py_NormalizeImmortalReference(PyObject *op)
 {
    assert(_Py_IsImmortal(op));
    PyInterpreterState *interp = _PyInterpreterState_GET();
    if (!_PyRefchain_IsTraced(interp, op)) {
        return;
    }
    PyInterpreterState *main_interp = _PyInterpreterState_Main();
    if (interp != main_interp
           && interp->feature_flags & Py_RTFLAGS_USE_MAIN_OBMALLOC)
    {
        assert(!_PyRefchain_IsTraced(main_interp, op));
        _PyRefchain_Remove(interp, op);
        _PyRefchain_Trace(main_interp, op);
    }
 }

 void
 _Py_ForgetReference(PyObject *op)
 {
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
    assert(*p);
 }

 #ifdef Py_TRACE_REFS
 extern void _Py_NormalizeImmortalReference(PyObject *);
 #endif

 static void
 immortalize_interned(PyObject *s)
 {
 #endif
    _PyUnicode_STATE(s).interned = SSTATE_INTERNED_IMMORTAL;
    _Py_SetImmortal(s);
 #ifdef Py_TRACE_REFS
    _Py_NormalizeImmortalReference(s);
 #endif
 }

 static /* non-null */ PyObject*
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2491,6 +2491,24 @@ _Py_ResurrectReference(PyObject *op)


		#ifdef Py_TRACE_REFS
		void
		_Py_NormalizeImmortalReference(PyObject *op)
Copy link Member naschemeOct 1, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Having some comment here would be helpful. Otherwise this function looks quite mysterious. Copy link MemberAuthor ericsnowcurrentlyOct 1, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. done! nascheme and gpshead reacted with thumbs up emoji
		{
		assert(_Py_IsImmortal(op));
		PyInterpreterState *interp = _PyInterpreterState_GET();
		if (!_PyRefchain_IsTraced(interp, op)) {
		return;
		}
		PyInterpreterState *main_interp = _PyInterpreterState_Main();
		if (interp != main_interp
		&& interp->feature_flags & Py_RTFLAGS_USE_MAIN_OBMALLOC)
		{
		assert(!_PyRefchain_IsTraced(main_interp, op));
		_PyRefchain_Remove(interp, op);
		_PyRefchain_Trace(main_interp, op);
		}
		}

		void
		_Py_ForgetReference(PyObject *op)
		{
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15437,6 +15437,10 @@ _PyUnicode_InternStatic(PyInterpreterState interp, PyObject *p)
		assert(*p);
		}

		#ifdef Py_TRACE_REFS
		extern void _Py_NormalizeImmortalReference(PyObject *);
		#endif

		static void
		immortalize_interned(PyObject *s)
		{
Expand All		@@ -15452,6 +15456,9 @@ immortalize_interned(PyObject *s)
		#endif
		_PyUnicode_STATE(s).interned = SSTATE_INTERNED_IMMORTAL;
		_Py_SetImmortal(s);
		#ifdef Py_TRACE_REFS
		_Py_NormalizeImmortalReference(s);
		#endif
		}

		static /* non-null / PyObject
Expand Down