Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-124309: Revert eager task factory fix to prevent breaking downstream#124810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…n to support eager task factories (python#124390)"This reverts commitde929f3.
This is a blocker for 3.12.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree. Hopefully it's not too late.@Yhg1s.
133e929 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@ZeroIntensity for the PR, and@Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…wnstream (pythonGH-124810)* Revert "pythonGH-124639: add back loop param to staggered_race (pythonGH-124700)"This reverts commite0a41a5.* Revert "pythongh-124309: Modernize the `staggered_race` implementation to support eager task factories (pythonGH-124390)"This reverts commitde929f3.(cherry picked from commit133e929)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
GH-124817 is a backport of this pull request to the3.12 branch. |
Thank you, Thomas! |
…ownstream (GH-124810) (#124817)gh-124309: Revert eager task factory fix to prevent breaking downstream (GH-124810)* Revert "GH-124639: add back loop param to staggered_race (GH-124700)"This reverts commite0a41a5.* Revert "gh-124309: Modernize the `staggered_race` implementation to support eager task factories (GH-124390)"This reverts commitde929f3.(cherry picked from commit133e929)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
cc@Yhg1s
The new implementation using
TaskGrouphas been causing a number of problems, and I'm not comfortable with it going into 3.12.7. Namely, 3.12.7 will break aiohttp and aiohappyeyeballs downstream. Seethis issue and some of the discussion fromthis issue.